Upload position was not being saved through rest api

WPChill · Oct 10, 2024 · 1ac329b · 1ac329b
1 parent d6b7697
commit 1ac329b
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 7 deletions.
diff --git a/Modula.php b/Modula.php
@@ -4,7 +4,7 @@
 * Plugin URI:               https://wp-modula.com/
 * Description:              Modula is the most powerful, user-friendly WordPress gallery plugin. Add galleries, masonry grids and more in a few clicks.
 * Author:                   WPChill
-* Version:                  2.10.2
+* Version:                  2.10.3
 * Author URI:               https://www.wpchill.com/
 * License:                  GPLv3 or later
 * License URI:              http://www.gnu.org/licenses/gpl-3.0.html
@@ -47,7 +47,7 @@
  * @since    2.0.2
  */
 
-define( 'MODULA_LITE_VERSION', '2.10.2' );
+define( 'MODULA_LITE_VERSION', '2.10.3' );
 define( 'MODULA_PATH', plugin_dir_path( __FILE__ ) );
 define( 'MODULA_URL', plugin_dir_url( __FILE__ ) );
 defined( 'MODULA_PRO_STORE_URL' ) || define( 'MODULA_PRO_STORE_URL', 'https://wp-modula.com' );

diff --git a/changelog.txt b/changelog.txt
@@ -1,3 +1,6 @@
+= 2.10.3 - 10.10.2024 =
+Fixed: Upload position setting not being saved.
+
 = 2.10.2 - 30.09.2024 =
 Added: Multiple columns for the Masonry gallery type
 Fixed: Sanitize captions for fancybox (security fix)

diff --git a/includes/admin/class-modula-cpt.php b/includes/admin/class-modula-cpt.php
@@ -432,8 +432,19 @@ private function sanitize_settings( $post_id, $settings ) {
 		}
 
 		// Save the value of upload_position.
-		if ( isset( $_POST['modula-settings']['upload_position'] ) ) {
-			$modula_settings['upload_position'] = sanitize_text_field( wp_unslash( $_POST['modula-settings']['upload_position'] ) );
+		if ( 
+			isset( $_POST['modula-settings']['upload_position'] ) 
+			|| isset($settings['upload_position'])
+		) {
+			$upload_position = isset( $_POST['modula-settings']['upload_position'] ) 
+				? $_POST['modula-settings']['upload_position'] 
+				: $settings['upload_position'];
+
+			$upload_position = '1' === $upload_position || 'start' === $upload_position 
+					? 'start' 
+					: 'end';
+
+			$modula_settings['upload_position'] = $upload_position;
 		} else {
 			$modula_settings['upload_position'] = 'end';
 		}

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
 	"name": "modula-best-grid-gallery",
-	"version": "2.10.2",
+	"version": "2.10.3",
 	"description": "Modula Image Gallery build tools",
 	"author": "WPChill",
 	"license": "GPL-2.0-or-later",
@@ -91,4 +91,4 @@
 		"glob": "^10.3.3",
 		"rimraf": "^5.0.1"
 	}
-}
+}
diff --git a/readme.txt b/readme.txt
@@ -4,7 +4,7 @@ Tags: best gallery plugin, image gallery, video gallery, free gallery, wordpress
 Requires at least: 5.3
 Tested up to: 6.6
 Requires PHP: 5.6
-Stable tag: 2.10.2
+Stable tag: 2.10.3
 
 License: GNU General Public License v3.0 or later
 The WordPress gallery plugin that's highly customizable & you can use to impress your clients. Create beautiful image galleries in minutes.
@@ -156,6 +156,8 @@ Free support is included only with a PRO license: [Buy Modula PRO](https://wp-mo
 4. Responsive galleries created with Modula
 
 == Changelog ==
+= 2.10.3 - 10.10.2024 =
+Fixed: Upload position setting not being saved.
 
 = 2.10.2 - 30.09.2024 =
 Added: Multiple columns for the Masonry gallery type