Skip to content

Conversation

@hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Jan 29, 2026

Notes

Please style as you see fit. The person icon is not quite centered vertically. :p

I'm wondering if we need to show the "(Period 1)" and "(All Periods)" in the tooltip. It clutters up the tooltip text a bit and makes it hard to read. Would the teachers usually know which period they're currently looking at and can get this info by looking at the period select drop-down?

Changes

  • Show teams on nodes (lessons and steps) in the Grade by Step view, if any
    • An icon, with a count appears if there are any teams on that node.
    • A tooltip should show students on that step
  • Changing periods should update the display to match the selected period (including all periods)
  • This should update in real-time as students move around in the unit.

Test

  • Above works as described

@hirokiterashima hirokiterashima self-assigned this Jan 29, 2026
@hirokiterashima hirokiterashima added the enhancement New feature of any size or improvement (UI, performance, security) label Jan 29, 2026
@qltysh
Copy link

qltysh bot commented Jan 29, 2026

Qlty

Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

Modified Files with Diff Coverage (2)

RatingFile% DiffUncovered Line #s
New file Coverage rating: A
...app/classroom-monitor/teams-on-node/teams-on-node.component.ts100.0%
New file Coverage rating: F
...mMonitorComponents/nodeProgress/nav-item/nav-item.component.ts100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@hirokiterashima hirokiterashima marked this pull request as ready for review January 29, 2026 23:33
Removed period text from NavItemProgress and TeamsOnNode tooltips.
Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

I updated styles and removed the period name from NavItemProgress and TeamsOnNode tooltips.

@hirokiterashima hirokiterashima merged commit 9ae1e06 into develop Feb 3, 2026
1 check passed
@hirokiterashima hirokiterashima deleted the grade-by-step-show-student-location branch February 3, 2026 01:01
@hirokiterashima
Copy link
Member Author

🎉 This PR is included in version 5.204.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature of any size or improvement (UI, performance, security) released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants