fix(VLE): Show notes launcher and chatbot toggle in tabbed mode#2258
fix(VLE): Show notes launcher and chatbot toggle in tabbed mode#2258
Conversation
❌ 1 blocking issue (1 total)
|
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
| it('should create', () => { | ||
| expect(component).toBeTruthy(); | ||
| }); | ||
| }); |
|
Coverage Impact Unable to calculate total coverage change because base branch coverage was not found. Modified Files with Diff Coverage (2)
🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|
hirokiterashima
left a comment
hirokiterashima
left a comment
There was a problem hiding this comment.
Seems to work for except for on a unit with many lessons? I don't see the buttons for notes and chatbot. Instead, I see a blank bar below the tabs, like this:
I also added some comments inline.
| @@ -0,0 +1,22 @@ | |||
| import { ComponentFixture, TestBed } from '@angular/core/testing'; | |||
|
|
|||
| selector: 'chatbot-launcher', | ||
| imports: [MatButtonModule, MatIconModule, MatTooltipModule], | ||
| templateUrl: './chatbot-launcher.component.html', | ||
| styleUrl: './chatbot-launcher.component.scss' |
There was a problem hiding this comment.
Remove line and empty file?
| export class ChatbotLauncherComponent { | ||
| @Output() toggleChatbot = new EventEmitter<void>(); | ||
|
|
||
| emitToggleChatbot(): void { |
There was a problem hiding this comment.
| emitToggleChatbot(): void { | |
| protected emitToggleChatbot(): void { |
hirokiterashima
left a comment
hirokiterashima
left a comment
There was a problem hiding this comment.
Discussed in person. Good to merge after changes. 👍
|
🎉 This PR is included in version 5.203.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
2 participants
Changes
Notes launcher and Chatbot toggle buttons were previously not show when unit uses the Tabbed navigation mode (making the tools inaccessible :
These changes show the Notes launcher and Chatbot toggle buttons next to the navigation tabs:
Test