feat(OpenResponse): Allow authors to specify student-friendly text for ideas#2130
feat(OpenResponse): Allow authors to specify student-friendly text for ideas#2130Aaron-Detre merged 9 commits intodevelopfrom
Conversation
hirokiterashima
left a comment
There was a problem hiding this comment.
Works as described.
"Idea name" => "Idea description" sounds good.
I'm wondering if we need to even have a checkbox to "Enable Student-Friendly Idea Descriptions". I think every CRater item can (and should) have a rubric going forward, so the idea description component should always be "enabled". Maybe we should alway show the rubric, but let the author to collapse/expand the section since it takes up a lot of vertical space? What do you think?
Also, see my comments inline.
...components/openResponse/edit-open-response-advanced/edit-open-response-advanced.component.ts
Outdated
Show resolved
Hide resolved
...components/openResponse/edit-open-response-advanced/edit-open-response-advanced.component.ts
Outdated
Show resolved
Hide resolved
...components/openResponse/edit-open-response-advanced/edit-open-response-advanced.component.ts
Outdated
Show resolved
Hide resolved
hirokiterashima
left a comment
There was a problem hiding this comment.
LGTM. I added minor code improvement suggestions to address before you merge. Remember to test using the pipeline.
...components/openResponse/edit-open-response-advanced/edit-open-response-advanced.component.ts
Outdated
Show resolved
Hide resolved
...mponents/openResponse/edit-open-response-advanced/edit-open-response-advanced.component.html
Outdated
Show resolved
Hide resolved
...mponents/openResponse/edit-open-response-advanced/edit-open-response-advanced.component.html
Outdated
Show resolved
Hide resolved
...components/openResponse/edit-open-response-advanced/edit-open-response-advanced.component.ts
Outdated
Show resolved
Hide resolved
|
🎉 This PR is included in version 5.174.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Changes
Test
Closes #2117