feat(Dialog Guidance): Summary display for teachers#2115
Merged
Aaron-Detre merged 7 commits intodevelopfrom Apr 8, 2025
Merged
feat(Dialog Guidance): Summary display for teachers#2115Aaron-Detre merged 7 commits intodevelopfrom
Aaron-Detre merged 7 commits intodevelopfrom
Conversation
hirokiterashima
requested changes
Mar 13, 2025
Member
hirokiterashima
left a comment
There was a problem hiding this comment.
Functionality works as described.
As we discussed today, let's change this component so that instead of showing just the "Most common ideas", we would
- show "Most common ideas" (shows top 3)
- show "Least common ideas" (shows top 3)
- show a link to "Show all ideas" (when clicked, shows all ideas in the rubric and their count)
Don't show any of the above if no ideas were detected by any of the students.
Also:
- add unit tests
- see inline comments for code improvement suggestions
...ise5/directives/teacher-summary-display/dialog-guidance-teacher-summary-display.component.ts
Outdated
Show resolved
Hide resolved
...ise5/directives/teacher-summary-display/dialog-guidance-teacher-summary-display.component.ts
Outdated
Show resolved
Hide resolved
...ise5/directives/teacher-summary-display/dialog-guidance-teacher-summary-display.component.ts
Outdated
Show resolved
Hide resolved
...ise5/directives/teacher-summary-display/dialog-guidance-teacher-summary-display.component.ts
Outdated
Show resolved
Hide resolved
...ise5/directives/teacher-summary-display/dialog-guidance-teacher-summary-display.component.ts
Outdated
Show resolved
Hide resolved
...ise5/directives/teacher-summary-display/dialog-guidance-teacher-summary-display.component.ts
Outdated
Show resolved
Hide resolved
...ise5/directives/teacher-summary-display/dialog-guidance-teacher-summary-display.component.ts
Outdated
Show resolved
Hide resolved
...ise5/directives/teacher-summary-display/dialog-guidance-teacher-summary-display.component.ts
Outdated
Show resolved
Hide resolved
...ise5/directives/teacher-summary-display/dialog-guidance-teacher-summary-display.component.ts
Outdated
Show resolved
Hide resolved
...ise5/directives/teacher-summary-display/dialog-guidance-teacher-summary-display.component.ts
Outdated
Show resolved
Hide resolved
hirokiterashima
requested changes
Mar 19, 2025
Member
hirokiterashima
left a comment
There was a problem hiding this comment.
New changes look good. 👍
I added code improvement suggestions on new code (and some older code that I had missed before).
Add i18n tags to elements and generate messages, and remember to add tests.
...e5/directives/teacher-summary-display/dialog-guidance-teacher-summary-display.component.html
Outdated
Show resolved
Hide resolved
...ise5/directives/teacher-summary-display/dialog-guidance-teacher-summary-display.component.ts
Outdated
Show resolved
Hide resolved
...ise5/directives/teacher-summary-display/dialog-guidance-teacher-summary-display.component.ts
Outdated
Show resolved
Hide resolved
...ise5/directives/teacher-summary-display/dialog-guidance-teacher-summary-display.component.ts
Outdated
Show resolved
Hide resolved
...ise5/directives/teacher-summary-display/dialog-guidance-teacher-summary-display.component.ts
Outdated
Show resolved
Hide resolved
hirokiterashima
approved these changes
Mar 25, 2025
Member
There was a problem hiding this comment.
LGTM. 👍
Can you do these before merge:
- Change fdescribe to describe
- Remove unused Config import in spec file
- Merge develop and regenerate messages. This should resolve the conflict
- Wait for @breity to review and style
breity
approved these changes
Apr 8, 2025
Member
|
🎉 This PR is included in version 5.173.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Test
Closes #2094