Skip to content

Reject if baudRate is zero#225

Merged
reillyeon merged 1 commit intomainfrom
baudrate_nonzero
Mar 2, 2026
Merged

Reject if baudRate is zero#225
reillyeon merged 1 commit intomainfrom
baudrate_nonzero

Conversation

@reillyeon
Copy link
Collaborator

@reillyeon reillyeon commented Feb 27, 2026

The documentation of the baudRate member of SerialOptions says that it must be a non-zero value but this was not checked by the method steps for open().

Fixed #224.

The documentation of the baudRate member of SerialOptions says that it must be a non-zero value but this was not checked by the method steps for open().
@reillyeon reillyeon requested a review from nondebug February 27, 2026 19:29
Copy link
Collaborator

@nondebug nondebug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@reillyeon reillyeon merged commit ff6568b into main Mar 2, 2026
2 checks passed
@reillyeon reillyeon deleted the baudrate_nonzero branch March 2, 2026 18:58
github-actions bot added a commit that referenced this pull request Mar 2, 2026
SHA: ff6568b
Reason: push, by reillyeon

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

open() should specify it should fail if baudRate is 0

2 participants