-
Notifications
You must be signed in to change notification settings - Fork 9
VIDSOL-34: Scroll/Zoom on ScreenShare #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
…croll-zoom-on-screenshare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements scroll/zoom functionality for screenshare components by creating a dedicated screenshare video tile with zoom and pan capabilities. The implementation replaces conditional logic in the existing Subscriber component with a specialized ScreenshareVideoTile component.
- Creates new ScreenshareVideoTile component with mouse wheel zoom and drag-to-pan functionality
- Adds ZoomIndicator component to show current zoom level and provide reset functionality
- Refactors Subscriber component to use ScreenshareVideoTile for screenshare content
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
frontend/src/components/Subscriber/Subscriber.tsx |
Refactored to use ScreenshareVideoTile for screenshare content, removing conditional UI logic |
frontend/src/components/MeetingRoom/ZoomIndicator/ |
New component displaying zoom level percentage and reset button |
frontend/src/components/MeetingRoom/ScreenshareVideoTile/ |
New specialized video tile with zoom/pan capabilities for screenshare content |
Comments suppressed due to low confidence (1)
frontend/src/components/Subscriber/Subscriber.tsx:1
- The
isScreenshare
prop is being removed from VideoTile but the line is still shown as removed. This suggests the prop may still be referenced in the VideoTile component definition and should be cleaned up there as well.
import { MouseEvent, ReactElement, useEffect, useRef, useState } from 'react';
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
frontend/src/components/MeetingRoom/ScreenshareVideoTile/ScreenshareVideoTile.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
What is this PR doing?
Subscribers should be able to Scroll and Zoom on Content Sharing.
How should this be manually tested?
Enter to the app and share screen. Then, open another tab with a subscriber so as to see the screen shared. You should see a zoom icon on the right down part of the screen sharing.
What are the relevant tickets?
A maintainer will add this ticket number.
Resolves VIDSOL-34
Checklist
[✅] Branch is based on
develop
(notmain
).[ ] Resolves a
Known Issue
.[ ] If yes, did you remove the item from the
docs/KNOWN_ISSUES.md
?[ ] Resolves an item reported in
Issues
.If yes, which issue? Issue Number?