Repository navigation
fix(ssh-config): ask each account before importing ~/.ssh/config (#557) - #565
Merged
Merged
Conversation
The plugin imported local hosts, keys and identities into whichever account was signed in, including a second, unrelated account on the same machine. It now asks once per account before the first sync and stores the answer in plugin storage, which is restored per account on sign-in. Declined or unanswered accounts get no initial sync, no watcher, and the Sync now button and MCP sync tool refuse. A settings toggle changes the answer. Accounts that already have ssh-config hosts keep syncing without a prompt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #557.
The SSH Config Sync plugin imported this machine's
~/.ssh/confighosts, keys and identities into the Personal vault of whichever account was signed in. That included a second, unrelated account (e.g. a customer's self-hosted account) used on the same workstation.What changes
import_consentin plugin storage. Plugin storage is restored per account on sign-in and account switch, so each account answers for itself. Dismissing the banner without answering asks again next launch. No prompt when~/.ssh/configis missing or has no usable hosts.synctool refuse too.alias_mapcounts as having said yes, so current users see no change after updating.toggleRowhelper.Not changed
~/.ssh/config.Verification
register.test.ts: 9 new tests. Forcing the gate open makes 8 of them fail.vitest run src/plugins/ssh-config: 34 passed.tests/pluginCatalogPublish.test.tspasses.tsc --noEmitclean,check-plugin-versionsOK.