Skip to content

Memory leak may happen, when calculated min thread. #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eitanmiz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Memory leak may happen, when calculated min thread. #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions VoltDB.Data.Client/Connections/Internal/CallbackExecutor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,11 @@ public void Start()
// calculation)
int workerThreads;
int completionPortThreads;
ThreadPool.GetMinThreads(out workerThreads, out completionPortThreads);
// **** the no. of worker thread shall be the no. of processors and not the minimum no. of threads of pool.
// ThreadPool.GetMinThreads(out workerThreads, out completionPortThreads);
workerThreads = Environment.ProcessorCount;
completionPortThreads = Environment.ProcessorCount;

int processingThreadCount = Math.Max(workerThreads - 3, 2); // -3 is for: 1 Client thread + at least 2 connection threads.
Threads = new Thread[processingThreadCount];

Expand Down Expand Up @@ -207,4 +211,4 @@ private void BackgroundThreadRun()
catch { }
}
}
}
}