Repository navigation
Conversation
Each check creates a task of its own (EVERY, DELAY or CRON; on the database or RUN ON PARTITIONS; ON ERROR LOG or IGNORE), lets it run, disables it and checks that it ran within its schedule's bounds, stopped after ALTER TASK DISABLE and shows DISABLED in @statistics TASK; a third of the checks run a failing procedure ON ERROR STOP and expect ERROR. Registered as TASK, counted in run-sqlancer.sh's summary and run-coverage.sh's oracle list. ENG-30680 (a database task runs in two chains after the MP leader's node fails with a call in flight): repros/ENG-30680.sh, and while avoiding known bugs in runs where nodes fail, the bounds allow twice the runs.
This was referenced Nov 13, 2026
Author
|
Superseded by #51, which combines every ENG-30396 PR of this repo into one. This PR's branch is kept, and its description still has this milestone's details and lab results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Milestone 39 of ENG-30396 (tracked in ENG-30581, epic ENG-30580 "SQL Housekeeping"). Stacked on #37; review that and the PRs below it first.
Why
Milestone 30's coverage run found scheduled tasks (
CREATE TASK) exercised little: the scheduler (TaskManager) and its schedules ran only at startup.What it changes
EVERY,DELAYorCRON; on the database orRUN ON PARTITIONS;ON ERROR LOGorIGNORE.ALTER TASK DISABLE:@Statistics TASKshows it asDISABLED.ON ERROR STOPand expect the task to showERROR.run-sqlancer.sh's summary andrun-coverage.sh's oracle list.Bugs found
--avoid-known-bugsis true@Statistics TASKmisses the second chain, and itsPROCEDURE_*times go to ±2.4e18. Reproduction:voltdb/repros/ENG-30680.sh(kill host 1 with a 20 ms delay). Blocker.Coverage
Milestone 41's coverage run, which included TASK:
TaskManager281 of 412 lines.Testing
mvn verifypasses.matrix-systemtest-apprunner-sqlancer(branch jobENG-30396-sqlancer-nightly, replays with these settings). They ran 16.1.0-SNAPSHOT (master kit 400) beside one node of 16.0.0, 45 minutes per run, with all thirty-one oracles.run-repros.shport wait and TASK's timing fix.