Tbcct 260 fe implement methodology section #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
atrincas
force-pushed
the
TBCCT-260-fe-implement-methodology-section
branch
from
e0ac989 to
170b29d
Compare
atrincas
force-pushed
the
TBCCT-260-fe-implement-methodology-section
branch
from
170b29d to
bc0f808
Compare
atrincas
changed the title
agnlez
reviewed
Feb 24, 2025
Comment on lines
30
to
36
| const navItems = useMemo(() => { | ||
| return METHODOLOGY_SECTIONS.map(({ id, title, href }) => ({ | ||
| id, | ||
| label: title, | ||
| href, | ||
| })); | ||
| }, []); |
There was a problem hiding this comment.
Isn't METHODOLOGY_SECTIONS static content? I would move this parse out of the Methodology function as there is nothing the parse depends on.
There was a problem hiding this comment.
Good point! Will do that
|
|
|
Scrolling down, the sidebar jumps from "Project costs – assumptions and methodology" to "Qualitative scorecard details and sources" without passing through "Model assumptions". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Methodology Page and Components
Changes
Jira