fix spatial shift for bboxes 2d #357
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also added a fix to frame spatial shift because when the shift was negative there was pixels at the border not being masked out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All actual changes are in the _spatial_shift function, everything else comes from the line wrapping which doesn't appear to be at the same format.
The issue was coming from the xcyc format and then clamp that would move the center and thus keep boxes that are outside the image.
Instead I just use the xyxy format making it work directly.
I'm not sure I understand why we did a min with ones before, I replaced everything with the clamp.