Skip to content

Conversation

@Violet2314
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Update dependency
  • Code style optimization
  • Test Case
  • Branch merge
  • Site / documentation update
  • Demo update
  • Workflow
  • Chore
  • Release
  • Other (about what?)

🔗 Related issue link

#3049

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

dragReorder_size?: number;
};

grid?: {};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不应该侵入到vTable的代码

@Violet2314 Violet2314 force-pushed the feat/gantt-add-theme-adaptation branch from 4174140 to 4716ddd Compare May 29, 2025 11:53
@github-actions github-actions bot removed the vtable label May 29, 2025
}
//#region gantt
export interface GanttConstructorOptions {
theme?: any;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

类型定义不合适

// vtable-gantt/src/ts-types/gantt-theme-define.ts

export interface IGanttTableThemeDefine {
grid?: Record<string, any>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

类型定义不合适

const CONTAINER_ID = 'vTable';

export function createTable() {
const records = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

demo加个切换主题的tab 各个主题都展示出来 把这个demo做好看一些 后面要放到官网上面

// ...可继续扩展其他主题字段
};

export class TableTheme {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

命名不要那vtable的直接用

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants