Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hackathon/create a knowledge graph using mock OMOP data (Team Sanofi US) #141

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PrithviPKamath
Copy link

@PrithviPKamath PrithviPKamath commented Mar 10, 2025

For authors

Description

Created a jupyter notebook as a first attempt at inserting data from csv files in OMOP format into a knowledge graph (networkx). csv files are uploaded into a folder called 'DataFiles'
This notebook will have to be enhanced to either update PrimeKG or use both knowledge graphs together. (We tried an attempt at am creating an LLM, but it fails for now)
There are no changes to the front end or any other aspect of the application.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests you conducted to verify your changes. These may involve creating new test scripts or updating existing ones.

  • Added new test(s) in the tests folder
  • Added new function(s) to an existing test(s) (e.g.: tests/testX.py)
  • No new tests added (Please explain the rationale in this case)

Checklist

  • My code follows the style guidelines mentioned in the Code/DevOps guides
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. MkDocs)
  • My changes generate no new warnings
  • I have added or updated tests (in the tests folder) that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

For reviewers

Checklist pre-approval

  • Is there enough documentation?
  • If a new feature has been added, or a bug fixed, has a test been added to confirm good behavior?
  • Does the test(s) successfully test edge/corner cases?
  • Does the PR pass the tests? (if the repository has continuous integration)

Checklist post-approval

  • Does this PR merge develop into main? If so, please make sure to add a prefix (feat/fix/chore) and/or a suffix BREAKING CHANGE (if it's a major release) to your commit message.
  • Does this PR close an issue? If so, please make sure to descriptively close this issue when the PR is merged.

Checklist post-merge

  • When you approve of the PR, merge and close it (Read this article to know about different merge methods on GitHub)
  • Did this PR merge develop into main and is it suppose to run an automated release workflow (if applicable)? If so, please make sure to check under the "Actions" tab to see if the workflow has been initiated, and return later to verify that it has completed successfully.

@lilijap lilijap self-assigned this Mar 10, 2025
Copy link
Contributor

@lilijap lilijap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PrithviPKamath, 👋

Thanks for your PR and creating a graph from the patient health record data! 🥳
How did you create these OMOP-standardized files from the initial spreadsheet, did you do it manually or used some scripts to do so?

I suggest considering an alternative path for these files/notebook. However, I'll defer to @awmulyadi to determine the most suitable location.

Thank you for your contributions!

@lilijap lilijap assigned PrithviPKamath and unassigned lilijap Mar 10, 2025
@PrithviPKamath
Copy link
Author

Hi @PrithviPKamath, 👋

Thanks for your PR and creating a graph from the patient health record data! 🥳 How did you create these OMOP-standardized files from the initial spreadsheet, did you do it manually or used some scripts to do so?

I suggest considering an alternative path for these files/notebook. However, I'll defer to @awmulyadi to determine the most suitable location.

Thank you for your contributions!

Hi @lilijap. Yes, the files were created manually since this was mock data. Converting real world databases to OMOP format would be a complete project in itself and my team does so in about 12 weeks time and make it available to downstream projects like this one. These files and location are temporary for the hackathon. Our databases are currently in Snowflake and with the right level of approvals you should be able to access them.

@lilijap
Copy link
Contributor

lilijap commented Mar 10, 2025

Hi @PrithviPKamath, 👋
Thanks for your PR and creating a graph from the patient health record data! 🥳 How did you create these OMOP-standardized files from the initial spreadsheet, did you do it manually or used some scripts to do so?
I suggest considering an alternative path for these files/notebook. However, I'll defer to @awmulyadi to determine the most suitable location.
Thank you for your contributions!

Hi @lilijap. Yes, the files were created manually since this was mock data. Converting real world databases to OMOP format would be a complete project in itself and my team does so in about 12 weeks time and make it available to downstream projects like this one. These files and location are temporary for the hackathon. Our databases are currently in Snowflake and with the right level of approvals you should be able to access them.

Thank you for this update. I look forward to hearing from you and your team regarding the conversion!

@gurdeep330 gurdeep330 changed the title Create a knowledge graph using mock OMOP data feat: hackathon/create a knowledge graph using mock OMOP data Mar 10, 2025
@gurdeep330 gurdeep330 changed the title feat: hackathon/create a knowledge graph using mock OMOP data feat: hackathon/create a knowledge graph using mock OMOP data (Team Sanofi US) Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants