Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in a hint[Name]=on styleCheck=error styleCheck=usages #182

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Fix errors in a hint[Name]=on styleCheck=error styleCheck=usages #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ggplotnim.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2302,7 +2302,7 @@
result = Theme(yMargin: some(margin.float),
yOutsideRange: orOpt)

proc margin*[T: string | UnitKind](left, right, top, bottom = NaN,

Check warning on line 2305 in src/ggplotnim.nim

View workflow job for this annotation

GitHub Actions / linux (devel) 

left, right, top, bottom all have default value 'NaN', this may be unintentional, either use ';' (semicolon) or explicitly write each default value [ImplicitDefaultValue]

Check warning on line 2305 in src/ggplotnim.nim

View workflow job for this annotation

GitHub Actions / linux (devel) 

left, right, top, bottom all have default value 'NaN', this may be unintentional, either use ';' (semicolon) or explicitly write each default value [ImplicitDefaultValue]

Check warning on line 2305 in src/ggplotnim.nim

View workflow job for this annotation

GitHub Actions / linux (devel) 

left, right, top, bottom all have default value 'NaN', this may be unintentional, either use ';' (semicolon) or explicitly write each default value [ImplicitDefaultValue]

Check warning on line 2305 in src/ggplotnim.nim

View workflow job for this annotation

GitHub Actions / linux (version-2-0) 

left, right, top, bottom all have default value 'NaN', this may be unintentional, either use ';' (semicolon) or explicitly write each default value [ImplicitDefaultValue]

Check warning on line 2305 in src/ggplotnim.nim

View workflow job for this annotation

GitHub Actions / linux (version-2-0) 

left, right, top, bottom all have default value 'NaN', this may be unintentional, either use ';' (semicolon) or explicitly write each default value [ImplicitDefaultValue]

Check warning on line 2305 in src/ggplotnim.nim

View workflow job for this annotation

GitHub Actions / linux (version-2-0) 

left, right, top, bottom all have default value 'NaN', this may be unintentional, either use ';' (semicolon) or explicitly write each default value [ImplicitDefaultValue]

Check warning on line 2305 in src/ggplotnim.nim

View workflow job for this annotation

GitHub Actions / windows (version-2-0) 

left, right, top, bottom all have default value 'NaN', this may be unintentional, either use ';' (semicolon) or explicitly write each default value [ImplicitDefaultValue]

Check warning on line 2305 in src/ggplotnim.nim

View workflow job for this annotation

GitHub Actions / windows (version-2-0) 

left, right, top, bottom all have default value 'NaN', this may be unintentional, either use ';' (semicolon) or explicitly write each default value [ImplicitDefaultValue]

Check warning on line 2305 in src/ggplotnim.nim

View workflow job for this annotation

GitHub Actions / windows (version-2-0) 

left, right, top, bottom all have default value 'NaN', this may be unintentional, either use ';' (semicolon) or explicitly write each default value [ImplicitDefaultValue]

Check warning on line 2305 in src/ggplotnim.nim

View workflow job for this annotation

GitHub Actions / windows (devel) 

left, right, top, bottom all have default value 'NaN', this may be unintentional, either use ';' (semicolon) or explicitly write each default value [ImplicitDefaultValue]

Check warning on line 2305 in src/ggplotnim.nim

View workflow job for this annotation

GitHub Actions / windows (devel) 

left, right, top, bottom all have default value 'NaN', this may be unintentional, either use ';' (semicolon) or explicitly write each default value [ImplicitDefaultValue]

Check warning on line 2305 in src/ggplotnim.nim

View workflow job for this annotation

GitHub Actions / windows (devel) 

left, right, top, bottom all have default value 'NaN', this may be unintentional, either use ';' (semicolon) or explicitly write each default value [ImplicitDefaultValue]
unit: T = ukCentimeter): Theme =
## Sets the margin around the actual plot. By default the given values are
## interpreted as `cm`. This can be changed using the `unit` argument, either
Expand Down Expand Up @@ -3360,7 +3360,7 @@
let xS = if theme.xRange.isSome: theme.xRange.unsafeGet else: filledScales.xScale
let xD = xS.high - xS.low
let yS = if theme.yRange.isSome: theme.yRange.unsafeGet else: filledScales.yScale
let yD = ys.high - ys.low
let yD = yS.high - yS.low
let ratio = yD / xD
let spacingLR = add(layout.left, layout.right)
doAssert spacingLR.unit == ukCentimeter
Expand Down
2 changes: 1 addition & 1 deletion src/ggplotnim/ggplot_drawing.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ proc drawRaster(view: var Viewport, fg: FilledGeom, df: DataFrame) =
numY = (height / hv).round.int
cMap = fg.colorScale

let α = if fg.geom.userstyle.alpha.isSome: fg.geom.userstyle.alpha.get else: 1.0
let α = if fg.geom.userStyle.alpha.isSome: fg.geom.userStyle.alpha.get else: 1.0
let αU32 = clamp(α * 255.0, 0.0, 255.0).uint32
var drawCb = proc(): seq[uint32] =
result = newSeq[uint32](df.len)
Expand Down
4 changes: 2 additions & 2 deletions src/ggplotnim/postprocess_scales.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,13 +362,13 @@ proc fillOptFields(fg: var FilledGeom, fs: FilledScales, df: var DataFrame) =
fg.invTrans = fs.invTransC
## Assign x / y scale of *raster* data
block RasterScales:
let xCol = df[xs.getColName]
let xCol = df[xS.getColName]
if xCol.kind in {colFloat, colInt}:
fg.rasterXScale = (low: xCol.toTensor(float).min, high: xCol.toTensor(float).max)
else:
raise newException(ValueError, "The `x` data aesthetics for the raster plot is neither " &
"`float` or `int` data. Instead it is: " & $xCol.kind)
let yCol = df[ys.getColName]
let yCol = df[yS.getColName]
if yCol.kind in {colFloat, colInt}:
fg.rasterYScale = (low: yCol.toTensor(float).min, high: yCol.toTensor(float).max)
else:
Expand Down
Loading