-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix with unmatched pair in string on previous line #71
Conversation
line with unmatched paren/bracket etc
Seems like I've fixed one bug, but introduced a lot of others. How to run tests? |
|
Thanks! |
@blueyed Hm, I thought that tests are failing. I still don't understand how to run them. I mean i run I don't know how to write tests for ruby, but if you would at least give me clear the instructions on how to run them properly I should be able to figure out how to write tests. |
Ah, the new commits were from you?! I find the tests very bad myself.. Try |
@blueyed I don't understand why, but while ci checks are passing on my machine the same code fails in every test. |
@purpleP |
Like I said a while ago already, it would be probably good to use Vader for new tests, and move the existing ones there. |
|
@blueyed I guess the main problem is the explained in the first lines. Bundle can't find vim, which I installed via |
And in case someone else would have time to write the test case it's basically looks like this
and the next line would be indented as column of |
Could not reproduce this. Is this still an issue for you? I think adding a test/fix would be easy then, but need to know the details. |
@blueyed Yes, I use custom syntax file where |
I think I will experiment with using |
Your own? Is it available somewhere? Otherwise see #99. |
@blueyed Yes, it is available https://github.com/purpleP/python-syntax.git |
line with unmatched paren/bracket etc
previously this would treat
[
on a previous line as a bracket that would be used to align the text on the next line as if this bracket should have a matched bracket. And would result in something like this.By the way, I've looked at the code and it's kinda awfull. Like instead of just finding parens with iteration it uses recursion and jumps over the file instead of using buffer indexing. Maybe this can be changed into using python ast module and define some rules about matching. You know, python indenting in python, instead of vimscript, seems more natural to me.