-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move generators into ViewComponent namespace #2130
base: v4
Are you sure you want to change the base?
Conversation
@paul how is this com ing along, do you need any help in getting the CI to Passs |
@reeganviljoen I haven't really looked into it. The CI failures are due to low coverage on completely unrelated files, so I assumed it had something to do with me branching my PR off v4 like @joelhawksley told me to. 😉 |
@paul i diddny realize, sorry. @joelhawksley are you able to see what failures are legit? |
@paul I think simple cover short-circuited due to |
@joelhawksley Ah, you're right, I didn't see that error at first. Its fixed now. Looks like the errors are releated to changes in Ruby main.
|
1eae092
to
d01779f
Compare
@paul I fixed CI on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally looks good to me. Mind updating the docs with the new command syntax and including a second sentence in the changelog summarizing the syntax changes?
What are you trying to accomplish?
#2112
ViewComponent generators pollute the generator namespace with a bunch of top level items, and claim the generic "component" name.
Before:
After
What approach did you choose and why?
I moved the generators into a ViewComponent module, instead of sitting at the top-level, so they end up namespaced in the
rails g
output. I also cleaned up the references to the files and classes within themselves, and in the tests.Anything you want to highlight for special attention from reviewers?