Adds prettify support for quoted UTF8 label and metric names #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
possibull
changed the title
hagen1778
reviewed
Feb 12, 2025
Refactored to use appendQuotedIdent Changed a test to use same() for readability
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #43 +/- ##
=========================================
Coverage ? 88.88%
=========================================
Files ? 11
Lines ? 3625
Branches ? 0
=========================================
Hits ? 3222
Misses ? 306
Partials ? 97 ☔ View full report in Codecov by Sentry. |
hagen1778
approved these changes
Feb 13, 2025
zekker6
approved these changes
Feb 13, 2025
|
@possibull This change was included into https://github.com/VictoriaMetrics/metricsql/releases/tag/v0.83.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for UTF8 metric and label names as detailed in #41