Fixed bug with not checking for errors before calling isMetricNameFil…

…ter()
VictoriaMetrics · Jan 14, 2025 · c8daf08 · c8daf08
1 parent 648dcb6
commit c8daf08
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/parser.go b/parser.go
@@ -887,13 +887,13 @@ func expandWithExpr(was []*withArgExpr, e Expr) (Expr, error) {
 					lfeNew.IsNegative = lfe.IsNegative
 					lfeNew.IsRegexp = lfe.IsRegexp
 					lf, err := lfeNew.toLabelFilter()
+					if err != nil {
+						return nil, err
+					}
 					if lf.isMetricNameFilter() {
 						metricName = lf.Value
 						continue
 					}
-					if err != nil {
-						return nil, err
-					}
 					lfsNew = append(lfsNew, *lf)
 				}
 				lfsNew = removeDuplicateLabelFilters(lfsNew)