Skip to content

fix: generate projects from bundled templates only#1626

Merged
marcossevilla merged 2 commits into
mainfrom
vgv-ai-bot/issue-1625
Jun 23, 2026
Merged

fix: generate projects from bundled templates only#1626
marcossevilla merged 2 commits into
mainfrom
vgv-ai-bot/issue-1625

Conversation

@very-good-code-bot

Copy link
Copy Markdown
Contributor

Summary

Changes the create command to always generate from the bundled template instead of fetching from the remote brick registry (brickhub.dev). This makes project generation deterministic, offline-first, and ensures users get exactly what we test and ship.

What Changed

  • Removed the remote brick fetch fallback in _getGeneratorForTemplate()
  • Removed the MasonGeneratorFromBrick typedef and _generatorFromBrick parameter from all create subcommands
  • Updated all create subcommands to only use generatorFromBundle
  • Simplified template resolution to always use template.bundle
  • Updated tests to reflect bundle-only generation path

Why This Matters

Before: The CLI used a caret constraint (e.g., ^1.3.3) to fetch bricks from the registry, which resolved to the latest compatible published version. The bundled version was only a fallback for offline scenarios.

Consequences:

  • Version mismatch: CLI bundles v1.3.3 but generates v1.4.0
  • Non-deterministic output: Template publishes change results without CLI releases
  • Untested paths: E2E tests validate latest published brick, not committed bundles
  • Upstream risks: Template releases can silently change/break create

After: Always generate from template.bundle, making:

  • ✅ Generated projects match the bundled template version
  • ✅ Deterministic output (no surprise updates from registry)
  • ✅ CLI is the single source of truth for templates
  • ✅ Faster generation (no network dependency)
  • ✅ Fully offline-capable

Template updates are now delivered only via CLI releases (via tool/generate_bundles.sh).

Testing

  • Removed tests for remote brick fetching and fallback behavior
  • Updated tests to verify generation uses the bundled template
  • All existing create tests continue to pass with the simplified path

Closes #1625

Closes #1625

Co-authored-by: ryzizub <ryzizub@users.noreply.github.com>
@marcossevilla marcossevilla merged commit 1f4e75f into main Jun 23, 2026
22 checks passed
@marcossevilla marcossevilla deleted the vgv-ai-bot/issue-1625 branch June 23, 2026 09:20
@vgvbot vgvbot mentioned this pull request Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: create should generate from the bundled template

1 participant