Conversation
The SetBatchLines -1 performance optimization in Citra-base.ahk was not propagating to dependent scripts because Citra-per-game.ahk and Default.ahk were importing a non-existent file name (CitraConfigBase.ahk) instead of the actual file (Citra-base.ahk). Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
There was a problem hiding this comment.
Pull request overview
This PR fixes broken AutoHotkey v1 #include paths in the legacy Citra per-game configuration scripts so they correctly pull in the shared base script (Citra-base.ahk) that sets critical performance directives (notably SetBatchLines, -1).
Changes:
- Update
#includeinDefault.ahkto referenceCitra-base.ahk(actual filename). - Update
#includeinCitra-per-game.ahkto referenceCitra-base.ahk(actual filename).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Other/Citra_per_game_config/Default.ahk | Fixes base include so performance/config directives from Citra-base.ahk apply to the default config script. |
| Other/Citra_per_game_config/Citra-per-game.ahk | Fixes base include so performance/config directives from Citra-base.ahk apply to the per-game applicator. |
💡 What: Corrected the #include file paths in
Citra-per-game.ahkandDefault.ahkfromCitraConfigBase.ahkto the actual filenameCitra-base.ahk.🎯 Why: The base script
Citra-base.ahkcontains#NoEnvandSetBatchLines, -1, but these critical performance and configuration directives were not propagating to the dependent scripts because the include path was incorrect (referencing the internal descriptive comment instead of the filename). This caused the scripts to run with the default 10ms delay between every executed line, causing significant slowdowns on string-intensive configuration tasks like parsing and replacing values inqt-config.ini.📊 Measured Improvement: By correcting the include path, the scripts now properly inherit the
SetBatchLines, -1directive, removing the default 10ms line execution delay. This effectively removes an artificial execution limit, theoretically maximizing the execution speed up to CPU limits instead of being bottlenecked by an arbitrary 10ms sleep between every single command andTF_Replaceinvocation. Due to execution environment constraints (no Wine), dynamic profiling could not be run, but this is a standard and massive AutoHotkey v1 optimization that fundamentally changes the runtime speed.PR created automatically by Jules for task 14356271632364093575 started by @Ven0m0