⚡ perf: Add SetBatchLines -1 to Citra Mod Manager#47
Conversation
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
There was a problem hiding this comment.
Pull request overview
This PR improves performance of the legacy AutoHotkey v1 Citra Mod Manager script by disabling AutoHotkey’s default execution throttling, aligning it with standard v1 “max speed” tuning used elsewhere in the repo.
Changes:
- Add
SetBatchLines, -1immediately after#NoEnvinCitra_Mod_Manager.ahkto run the script at maximum possible speed (no per-line sleep).
💡 What: Added
SetBatchLines, -1toOther/Citra_mods/Citra_Mod_Manager.ahkright after#NoEnv.🎯 Why: In legacy AutoHotkey v1 scripts, by default there is a 10ms sleep automatically inserted after every executing line. Adding
SetBatchLines, -1disables this behavior entirely, allowing loops (like the file system and CSV parsing loops within the script) and general execution to run at maximum possible speed, which is a critical and standard optimization for AHK v1 code.📊 Measured Improvement: No runtime benchmark could be performed because the current Linux environment lacks Wine and native Windows execution capabilities, making dynamic execution and performance measurement impossible. However, the theoretical improvement is undeniable and universally accepted: it removes a fixed 10ms-per-line sleep delay across all AutoHotkey execution loops within the script.
PR created automatically by Jules for task 6770896811078666104 started by @Ven0m0