Skip to content

Commit

Permalink
handle error in rollback
Browse files Browse the repository at this point in the history
If the rollback fails, the error was not handled properly, since the value of response is undefined.
  • Loading branch information
taukakao authored Dec 12, 2024
1 parent 61a724d commit cf55153
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion cmd/rollback.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,11 @@ func rollback(cmd *cobra.Command, args []string) error {
}

response, err := aBsys.Rollback(checkOnly)
if err != nil {
cmdr.Error.Println(err)
os.Exit(2)
return err
}
switch response {
case core.ROLLBACK_RES_YES:
// NOTE: the following strings could lead to misinterpretation, with
Expand All @@ -78,7 +83,7 @@ func rollback(cmd *cobra.Command, args []string) error {
cmdr.Info.Println(abroot.Trans("rollback.rollbackSuccess"))
os.Exit(0)
case core.ROLLBACK_FAILED:
cmdr.Info.Println(abroot.Trans("rollback.rollbackFailed", err))
cmdr.Error.Println(abroot.Trans("rollback.rollbackFailed", err))
os.Exit(1)
return err
}
Expand Down

0 comments on commit cf55153

Please sign in to comment.