-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
81 level of information database #85
81 level of information database #85
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
@i-be-snek , I see, and I have a question about the evaluation, so when we detect the location to map the L3 event, Location "Oregon" will be looked as the same with the location "Oregon, United States" or not? If not, then the model will get a penalty score? |
@liniiiiii If you think this is confusing or inconsistent, I can strip ",United States" from the output whenever we get that result back from OSM. It's not a big problem. |
@i-be-snek , I see, so we will normalize to the same name and GID, and match them, then there is no need to spend time to strip the country, and in the final database, it's also fine to keep it! |
@i-be-snek , for the 1st and 3rd tasks, I think the script is ready to proceed, and I wonder what is the 2nd task for a new empty database? |
@liniiiiii For the 2nd task, it would be great if you could take a peak inside |
a42ceef
to
1f93227
Compare
This includes updating compiled files
I've now pushed some changes so that all table columns, whether in the gold or the database, comply with our new selected names. The changes have not been made yet for the parsing, but will be soon in #88! Right now the changes are only reflected in the gold data and the database schema |
@i-be-snek , hi, thanks, I checked the impactdb.v1.db, it's matched with the variable names as we discussed! |
@liniiiiii That's great, thanks! I'm going to merge this with 81-level-of-information-dev. I will merge the other branches for Issue #81 there too until it all looks good. |
- The new database schema corresponds with the drawio png image - There is a new empty database - We can extract L1-3 from the flat excel. Note: we don't have the final data for that, only a working copy since more edits are required in the flat data table, but as long as we have a file that exactly matches the template in the excel sheet, we should have no problems
- The new database schema corresponds with the drawio png image - There is a new empty database - We can extract L1-3 from the flat excel. Note: we don't have the final data for that, only a working copy since more edits are required in the flat data table, but as long as we have a file that exactly matches the template in the excel sheet, we should have no problems
- The new database schema corresponds with the drawio png image - There is a new empty database - We can extract L1-3 from the flat excel. Note: we don't have the final data for that, only a working copy since more edits are required in the flat data table, but as long as we have a file that exactly matches the template in the excel sheet, we should have no problems
- The new database schema corresponds with the drawio png image - There is a new empty database - We can extract L1-3 from the flat excel. Note: we don't have the final data for that, only a working copy since more edits are required in the flat data table, but as long as we have a file that exactly matches the template in the excel sheet, we should have no problems
- The new database schema corresponds with the drawio png image - There is a new empty database - We can extract L1-3 from the flat excel. Note: we don't have the final data for that, only a working copy since more edits are required in the flat data table, but as long as we have a file that exactly matches the template in the excel sheet, we should have no problems
- The new database schema corresponds with the drawio png image - There is a new empty database - We can extract L1-3 from the flat excel. Note: we don't have the final data for that, only a working copy since more edits are required in the flat data table, but as long as we have a file that exactly matches the template in the excel sheet, we should have no problems
- The new database schema corresponds with the drawio png image - There is a new empty database - We can extract L1-3 from the flat excel. Note: we don't have the final data for that, only a working copy since more edits are required in the flat data table, but as long as we have a file that exactly matches the template in the excel sheet, we should have no problems
- The new database schema corresponds with the drawio png image - There is a new empty database - We can extract L1-3 from the flat excel. Note: we don't have the final data for that, only a working copy since more edits are required in the flat data table, but as long as we have a file that exactly matches the template in the excel sheet, we should have no problems
- The new database schema corresponds with the drawio png image - There is a new empty database - We can extract L1-3 from the flat excel. Note: we don't have the final data for that, only a working copy since more edits are required in the flat data table, but as long as we have a file that exactly matches the template in the excel sheet, we should have no problems
This PR is one part of Issue #81.
The idea is to try to get everything from #81 to work in separate branches:
Each branch represents a checkpoint to complete Issue #81, so its progress will be merged gradually into 81-level-of-information-dev. Once the changes from all three sub-branches are in 81-level-of-information-dev and we know they work without problems, 81-level-of-information-dev can be merged with main.
Overview of the changes:
Required to merge with 81-level-of-information-dev:
@liniiiiii could you please check these three things specified in the list above? If you think they make sense, please tick the box. If you find anything funny, let me know.