comment out the initial country check

[MurathanKurfali]

The pycountry-based initial country check is commented out.

[i-be-snek]

I thought about this for a bit... the issue was that we used to get a long list of locations where countries are mixed with area names.

@liniiiiii is this still the case?

If yes, we will then replace the method simple_country_check with either:

• (A) a lookup method that uses UNSD and GADM instead -- one problem here is that GADM and UNSD only have the official names.
• (B) a lookup method that shoots a request to OpenStreetMap to see if a Location exists as a "country" level administrative areas.

If no, then we simply drop these lines altogether and merge with main

[MurathanKurfali]

Whichever method we decide to continue with, I think it would be nice to run it on the gold data as well to make sure that everything we have there is classified as "country".

[liniiiiii]

Whichever method we decide to continue with, I think it would be nice to run it on the gold data as well to make sure that everything we have there is classified as "country".

Yeah, I plan to ask how to proceed this as well, let me run the dev set in the parse_events.py I revised for this function now, and to see if the code works!

[i-be-snek]

@liniiiiii so just to ask you again, we will have lists with mixed locations (countries and non-countries), is that correct?

[liniiiiii]

@liniiiiii so just to ask you again, we will have lists with mixed locations (countries and non-countries), is that correct?

@i-be-snek , yes, oh, no, really delayed response!

[i-be-snek]

Great, thanks @liniiiiii, good to know :)

[i-be-snek]

Since @liniiiiii is saying we will not have columns where country and location names are mixed, this function will be deprecated in #81

Unless I understood you incorrectly? Because your sentence had both a yes and a no?

[liniiiiii]

Since @liniiiiii is saying we will not have columns where country and location names are mixed, this function will be deprecated in #81

Unless I understood you incorrectly? Because your sentence had both a yes and a no?

My bad!!!! Yes is for the question, no is for my sorry of the late response :(