Drop events with no L1/L2/L3 impacts (or NULL impacts) #195
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Total_*_Min
/Total_*_Max
are empty)While working on this PR, I've discovered a bug: if an event ID doesn't exist in L2, but there is some L3 data, the data is not propagated to L2, and hence never moves up to L1. These events are NOT dropped in this PR, but are instead shown in the logs. In the entire database, there are only 17 instances (from 10 events) of this. This bug can be tackled in another PR.
In total, 94 event IDs are found to have no impact but only 84 event IDs are dropped because of the bug described above.