Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full run raw #188

Merged
merged 8 commits into from
Nov 9, 2024
Merged

Full run raw #188

merged 8 commits into from
Nov 9, 2024

Conversation

i-be-snek
Copy link
Collaborator

This PR has fixes for a small bug that caused full run failures in 9 files (out of 135).
The new raw version of the database will be pushed here too.

@i-be-snek i-be-snek changed the title WIP: Full run raw Full run raw Nov 8, 2024
@i-be-snek i-be-snek requested a review from liniiiiii November 8, 2024 22:56
@i-be-snek
Copy link
Collaborator Author

@liniiiiii it took a while but it's done now :) could you please take a look at the database? it would be useful to see how your plots would look now after the bug fixes.

Copy link
Collaborator

@liniiiiii liniiiiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with local test, the error events (terrorist attack) are filtered, and the GID issue is fixed with all three levels, thanks!

@liniiiiii liniiiiii merged commit cbaf4d0 into main Nov 9, 2024
1 check passed
@i-be-snek i-be-snek deleted the full_run_raw branch January 17, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants