-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
173 null dam error #183
173 null dam error #183
Conversation
@i-be-snek , big thanks for the update, I found an issue with this is that after the changes, the Adminstrative_Area_Norm becomes None in the records of events where I found the T C Null Dam. The event 8Lbci8N and iAAUPM5 contain T C Null Dam in the original Specific_Instance_Per_Administrative_Area_Affected/0000.parquet file, and then I ran the command you provided in this branch, then I open the same file, and the T C Null Dam records are gone, but for these Adminstrative_Area_Norm/Geojson/GID all became None, not only for these two events, but for all events in this file, similarly for other L3 files, could you have a look? For L2 and L1 it's fine, thanks! |
Thanks @liniiiiii. I'm still a bit sick today bit this seems easy to fix. I'll also be pushing another PR soon to filter out things like "country1"/"location2", etc where the model is hallucinating the instructions. |
@i-be-snek , get better soon!!! I will help with code review! Thanks! |
@liniiiiii I re-ran the parsing and insertion from scratch on the file Could you share the file you were inspecting on your end, or re-run the pipeline? I did add one commit that improves cleaning out "None" values from lists of locations/areas. |
@liniiiiii it should be okay now :) please try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR:
None
or removed altogether.[]
in case it's empty instead ofNone
To test this PR, you can try:
parsing events of an existing file that used to contain "T C Null Dam entries". Example:
evaluating a file parsed after the changes in this PR
database insertion after parsing with the changes in this PR