-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currency Conversion and Inflation Adjustment #180
Conversation
Formula to convert currencies
Formula for inflation adjustment , using this table Database/data/inflation_Index_2024.csv
Formula for USD to EUR (after data gap in USD, and keep it in another db file)
@i-be-snek , could you help to implement this in the database version, for the EUR, we can leave it a bit later, we will use the USD version for visualization, thanks! Any questions pls comment! 👍 |
… for monetary impacts for now
d7b20a6
to
46d61be
Compare
I realize now that the data gap cannot be done after the inflation adjustment and currency conversion because l2/l3 records often have the year missing, and with no year, there is no way to convert the currency and adjust for inflation in USD. So to achieve the goal of this PR, at least the year gap must be filled first. My understanding is that we want to release 3 databases: raw, inflation adjusted, and data-gap filled (in short). filling are done together. Another reason is that we cannot fill the data gap for monetary categories (like Damage) without first adjusting for inflation. So I think it may be better that inflation adjustment and the data gap are handled in a single step and we release 2 databases instead. What do you think? The code for this is almost in place, so I would just need to confirm with you here that it's okay to do it in one go. |
@i-be-snek , sorry for my late response, let's split them step by step, so the data gap should cover the damage columns as well, I think we can release the processed database with currency conversion, inflation adjusted, and data gap. Now we have the year gap fixed in the pr #174 (comment), could we use the output from this pr, and process with currency conversion and inflation adjusted, and then, an extra step is to fix the data gap of the damage columns. So we can only release two versions of databases, the raw one, and the processed one, thanks! |
@liniiiiii It wasn't late at all :D I had messaged in the weekend in hopes you would see it today (Monday). So, what we are now going to do is perform inflation adjustment and currency conversion as part of the data-gap filling, and then in the end we release two databases: one raw, and one 'post-processed', and the post-processed will have all currencies converted to USD and adjusted to 2024 plus all data gaps filled. Is that correct? |
Yes! Absolutely, that's what we will release! |
…he data gap filling
Closing to open #191 |
Upload the table for currency conversion and inflation adjusted to 2024. Ready to review!