renaming

unite test coverage

src/main/kotlin/com/vauthenticator/server/keys/KeyConfig.kt

@@ -4,7 +4,7 @@ import com.vauthenticator.server.keys.adapter.dynamo.DynamoDbKeyStorage
 import com.vauthenticator.server.keys.adapter.jdbc.JdbcKeyStorage
 import com.vauthenticator.server.keys.adapter.kms.KmsKeyDecrypter
 import com.vauthenticator.server.keys.adapter.kms.KmsKeyGenerator
-import com.vauthenticator.server.keys.adapter.local.*
+import com.vauthenticator.server.keys.adapter.java.*
 import com.vauthenticator.server.keys.domain.*
 import org.springframework.beans.factory.annotation.Value
 import org.springframework.context.annotation.Bean
@@ -25,12 +25,12 @@ class KeyConfig {
 
     @Profile("!kms")
     @Bean("keyGenerator")
-    fun bouncyCastleKeyGenerator(
+    fun JavaSecurityKeyGenerator(
         kmsClient: KmsClient,
-        storage: BouncyCastleKeyGeneratorMasterKeyStorage
-    ): KeyGenerator = BouncyCastleKeyGenerator(
+        storage: KeyGeneratorMasterKeyStorage
+    ): KeyGenerator = JavaSecurityKeyGenerator(
         KeyCryptographicOperations(
-            BouncyCastleKeyGeneratorMasterKeyRepository(storage)
+            KeyGeneratorMasterKeyRepository(storage)
         )
     )
 
@@ -40,13 +40,13 @@ class KeyConfig {
 
     @Profile("!kms")
     @Bean("keyDecrypter")
-    fun bouncyCastleKeyDecrypter(
+    fun JavaSecurityKeyDecrypter(
         @Value("\${key.master-key}") maserKid: String,
-        storage: BouncyCastleKeyGeneratorMasterKeyStorage
-    ): KeyDecrypter = BouncyCastleKeyDecrypter(
+        storage: KeyGeneratorMasterKeyStorage
+    ): KeyDecrypter = JavaSecurityKeyDecrypter(
         maserKid,
         KeyCryptographicOperations(
-            BouncyCastleKeyGeneratorMasterKeyRepository(storage)
+            KeyGeneratorMasterKeyRepository(storage)
         )
     )
 

src/main/kotlin/com/vauthenticator/server/keys/adapter/local/BouncyCastleKeyDecrypter.kt → src/main/kotlin/com/vauthenticator/server/keys/adapter/java/JavaSecurityKeyDecrypter.kt

@@ -1,11 +1,10 @@
-package com.vauthenticator.server.keys.adapter.local
+package com.vauthenticator.server.keys.adapter.java
 
 import com.vauthenticator.server.extentions.encoder
 import com.vauthenticator.server.keys.domain.KeyDecrypter
 import com.vauthenticator.server.keys.domain.MasterKid
-import org.springframework.beans.factory.annotation.Value
 
-class BouncyCastleKeyDecrypter(
+class JavaSecurityKeyDecrypter(
     private val maserKid: String,
     private val keyCryptographicOperations: KeyCryptographicOperations
 ) : KeyDecrypter {

src/main/kotlin/com/vauthenticator/server/keys/adapter/local/BouncyCastleKeyGenerator.kt → src/main/kotlin/com/vauthenticator/server/keys/adapter/java/JavaSecurityKeyGenerator.kt

@@ -1,12 +1,12 @@
-package com.vauthenticator.server.keys.adapter.local
+package com.vauthenticator.server.keys.adapter.java
 
 import com.vauthenticator.server.keys.domain.DataKey
 import com.vauthenticator.server.keys.domain.KeyGenerator
 import com.vauthenticator.server.keys.domain.MasterKid
 import java.util.*
 
 
-class BouncyCastleKeyGenerator(
+class JavaSecurityKeyGenerator(
     private val keyCryptographicOperations: KeyCryptographicOperations
 ) : KeyGenerator {
 

src/main/kotlin/com/vauthenticator/server/keys/adapter/local/KeyCryptographicOperations.kt → src/main/kotlin/com/vauthenticator/server/keys/adapter/java/KeyCryptographicOperations.kt

@@ -1,4 +1,4 @@
-package com.vauthenticator.server.keys.adapter.local
+package com.vauthenticator.server.keys.adapter.java
 
 import com.vauthenticator.server.extentions.decoder
 import com.vauthenticator.server.keys.domain.MasterKid
@@ -12,11 +12,11 @@ import javax.crypto.spec.SecretKeySpec
 
 
 class KeyCryptographicOperations(
-    private val repository: BouncyCastleKeyGeneratorMasterKeyRepository,
+    private val repository: KeyGeneratorMasterKeyRepository
 ) {
     companion object {
         init {
-            Security.addProvider(BouncyCastleProvider());
+            Security.addProvider(BouncyCastleProvider())
         }
     }
 

src/main/kotlin/com/vauthenticator/server/keys/adapter/local/BouncyCastleKeyGeneratorMasterKeyRepository.kt → src/main/kotlin/com/vauthenticator/server/keys/adapter/java/KeyGeneratorMasterKeyRepository.kt

@@ -1,4 +1,4 @@
-package com.vauthenticator.server.keys.adapter.local
+package com.vauthenticator.server.keys.adapter.java
 
 import com.vauthenticator.server.keys.domain.MasterKid
 import org.springframework.boot.context.properties.ConfigurationProperties
@@ -7,8 +7,8 @@ import org.springframework.context.annotation.Configuration
 import org.springframework.context.annotation.Profile
 
 
-class BouncyCastleKeyGeneratorMasterKeyRepository(
-    val storage: BouncyCastleKeyGeneratorMasterKeyStorage
+class KeyGeneratorMasterKeyRepository(
+    val storage: KeyGeneratorMasterKeyStorage
 ) {
 
     fun maskerKeyFor(masterKeyId: MasterKid): String {
@@ -19,12 +19,12 @@ class BouncyCastleKeyGeneratorMasterKeyRepository(
 
 @Profile("!kms")
 @Configuration(proxyBeanMethods = false)
-@EnableConfigurationProperties(BouncyCastleKeyGeneratorMasterKeyStorage::class)
-class BouncyCastleKeyGeneratorMasterKeyRepositoryConfig {
+@EnableConfigurationProperties(KeyGeneratorMasterKeyStorage::class)
+class KeyGeneratorMasterKeyRepositoryConfig {
 
 }
 
 @ConfigurationProperties(prefix = "key.master-key.storage")
-data class BouncyCastleKeyGeneratorMasterKeyStorage(val content: Map<String, String>) {
+data class KeyGeneratorMasterKeyStorage(val content: Map<String, String>) {
 
 }

src/main/kotlin/com/vauthenticator/server/keys/adapter/local/KeyInitJob.kt → src/main/kotlin/com/vauthenticator/server/keys/adapter/java/KeyInitJob.kt

@@ -1,4 +1,4 @@
-package com.vauthenticator.server.keys.adapter.local
+package com.vauthenticator.server.keys.adapter.java
 
 import com.vauthenticator.server.keys.domain.*
 import org.springframework.beans.factory.annotation.Value

src/test/kotlin/com/vauthenticator/server/keys/adapter/java/JavaSecurityKeyDecrypterTest.kt

@@ -0,0 +1,33 @@
+package com.vauthenticator.server.keys.adapter.java
+
+import com.vauthenticator.server.extentions.encoder
+import com.vauthenticator.server.keys.domain.MasterKid
+import io.mockk.every
+import io.mockk.impl.annotations.MockK
+import io.mockk.junit5.MockKExtension
+import org.junit.jupiter.api.Assertions
+import org.junit.jupiter.api.Test
+import org.junit.jupiter.api.extension.ExtendWith
+
+@ExtendWith(MockKExtension::class)
+class JavaSecurityKeyDecrypterTest {
+
+    @MockK
+    lateinit var keyCryptographicOperations: KeyCryptographicOperations
+
+    @Test
+    fun `happy path`() {
+        val encrypted = "AN_ENCRYPTED_VALUE"
+        val decrypted = "AN_UNENCRYPTED_VALUE".toByteArray()
+        val maserKid = "A_MASTER_KEY"
+
+        val uut = JavaSecurityKeyDecrypter(maserKid, keyCryptographicOperations)
+
+        every { keyCryptographicOperations.decryptKeyWith(MasterKid(maserKid), encrypted.toByteArray()) } returns decrypted
+
+        val actual = uut.decryptKey(encrypted)
+        val expected = encoder.encode(decrypted).decodeToString()
+
+        Assertions.assertEquals(expected, actual)
+    }
+}

src/test/kotlin/com/vauthenticator/server/keys/adapter/java/JavaSecurityKeyGeneratorTest.kt

@@ -0,0 +1,4 @@
+package com.vauthenticator.server.keys.adapter.java
+
+//todo
+class JavaSecurityKeyGeneratorTest

src/test/kotlin/com/vauthenticator/server/keys/adapter/java/KeyCryptographicOperationsTest.kt

@@ -0,0 +1,4 @@
+package com.vauthenticator.server.keys.adapter.java
+
+//todo
+class KeyCryptographicOperationsTest

src/test/kotlin/com/vauthenticator/server/keys/adapter/java/KeyGeneratorMasterKeyRepositoryTest.kt

@@ -0,0 +1,4 @@
+package com.vauthenticator.server.keys.adapter.java
+
+//todo
+class KeyGeneratorMasterKeyRepositoryTest