fix: improved e2e test

.eslintrc.js

@@ -1,24 +1,24 @@
 module.exports = {
-  parser: '@typescript-eslint/parser',
+  parser: "@typescript-eslint/parser",
   parserOptions: {
-    project: 'tsconfig.json',
-    sourceType: 'module',
+    project: "tsconfig.json",
+    sourceType: "module",
   },
-  plugins: ['@typescript-eslint/eslint-plugin'],
+  plugins: ["@typescript-eslint/eslint-plugin"],
   extends: [
-    'plugin:@typescript-eslint/recommended',
-    'plugin:prettier/recommended',
+    "plugin:@typescript-eslint/recommended",
+    "plugin:prettier/recommended",
   ],
   root: true,
   env: {
     node: true,
     jest: true,
   },
-  ignorePatterns: ['.eslintrc.js'],
+  ignorePatterns: [".eslintrc.js"],
   rules: {
-    '@typescript-eslint/interface-name-prefix': 'off',
-    '@typescript-eslint/explicit-function-return-type': 'off',
-    '@typescript-eslint/explicit-module-boundary-types': 'off',
-    '@typescript-eslint/no-explicit-any': 'off',
+    "@typescript-eslint/interface-name-prefix": "off",
+    "@typescript-eslint/explicit-function-return-type": "off",
+    "@typescript-eslint/explicit-module-boundary-types": "off",
+    "@typescript-eslint/no-explicit-any": "off",
   },
 };

TODO.md

@@ -8,11 +8,7 @@
 
 ## ez
 
-- fer delete user
 - acabar de mirar retornos
 - posarli fastify ( problemes de versió, crec que per passport, deixar per a més avant)
 
 ## hard
-
-- no puc pasarli variables env a la github action de 2e2
-- usar un pas de la action pa crear una bd???

package.json

@@ -17,7 +17,7 @@
     "test": "jest --runInBand --detectOpenHandles  --config ./jest.config.json",
     "test:watch": "jest --watch",
     "test:cov": "jest --coverage",
-    "e2e": "jest --runInBand --detectOpenHandles --forceExit --config ./test/jest-e2e.json"
+    "e2e": "jest --runInBand --forceExit --config ./test/jest-e2e.json"
   },
   "dependencies": {
     "@nestjs/common": "^9.1.2",

src/dto/deleteUser.dto.ts

@@ -0,0 +1,4 @@
+export class DeleteUserDto {
+  email: string;
+  password: string;
+}

src/user/user.controller.ts

@@ -1,13 +1,14 @@
 import {
-  BadRequestException,
   Body,
   Controller,
+  Delete,
   Get,
   Param,
   Patch,
   Post,
   UseGuards,
 } from "@nestjs/common";
+import { DeleteUserDto } from "src/dto/deleteUser.dto";
 import { Public } from "../auth/decorators/public.decorator";
 import { ApiKeyGuard } from "../auth/guards/api-key.guard";
 import { LocalAuthGuard } from "../auth/guards/local-auth.guard";
@@ -58,12 +59,20 @@ export class UserController {
     return this.userService.update(dto);
   }
 
+  @UseGuards(LocalAuthGuard)
+  @Delete("delete")
+  public async deleteUser(@Body() dto: DeleteUserDto): Promise<boolean> {
+    return this.userService.deleteUser(dto);
+  }
+
   @Post("signUp")
   @Public()
   public async signUp(@Body() dto: createUserDto): Promise<SafeUserType> {
     try {
       return await this.userService.signUp(dto);
     } catch (e) {
+      console.log(e);
+
       const error = await this.userErrorService.saveError(e);
       throw error;
     }

src/user/user.service.ts

@@ -6,6 +6,7 @@ import { UpdateUserDto } from "src/dto/updateUserDto";
 import { User, UserDocument } from "./schemas/user.schema";
 import * as bycript from "bcrypt";
 import { SafeUserType, UserType } from "src/auth/types/types";
+import { DeleteUserDto } from "src/dto/deleteUser.dto";
 
 @Injectable()
 export class UserService {
@@ -46,4 +47,11 @@ export class UserService {
     const { password, __v, ...rta } = updatedUser.toJSON();
     return rta as SafeUserType;
   }
+
+  public async deleteUser(dto: DeleteUserDto): Promise<boolean> {
+    const { deletedCount } = await this.userModel
+      .deleteOne({ email: dto.email })
+      .exec();
+    return deletedCount > 0;
+  }
 }

test/app.e2e-spec.ts

@@ -5,7 +5,7 @@ import { AppModule } from "./../src/app.module";
 
 describe("Starting App", () => {
   let app: INestApplication;
-  let randomUser = (Math.random() + 1).toString(36).substring(7);
+  const randomUser = (Math.random() + 1).toString(36).substring(7);
   let httpServer: any;
   //mirar si pug afafar la conexió com michael guay
 
@@ -29,11 +29,9 @@ describe("Starting App", () => {
       const response = await request(httpServer)
         .get("/user/get")
         .set("Auth", "abc");
-
       expect(response.status).toBe(200);
     });
   });
-
   describe("USER create a user /user/signup (POST)", () => {
     it("should create  a user", async () => {
       const response = await request(httpServer)
@@ -46,6 +44,10 @@ describe("Starting App", () => {
       //arreplegar id y pasarliu a getById
 
       expect(response.status).toBe(201);
+      expect(response.body).toMatchObject({
+        name: randomUser,
+        email: `${randomUser}@mail.com`,
+      });
     });
   });
 
@@ -59,6 +61,14 @@ describe("Starting App", () => {
         });
 
       expect(response.status).toBe(201);
+      expect(response.body).toMatchObject({
+        access_token: expect.any(String),
+        user: {
+          _id: expect.any(String),
+          name: randomUser,
+          email: `${randomUser}@mail.com`,
+        },
+      });
     });
   });
 
@@ -76,7 +86,7 @@ describe("Starting App", () => {
     //TODO: tornar resposta sencera
   });
   describe("USER update the user just created /user/update (PATCH)", () => {
-    it("should delete the user", async () => {
+    it("should uypdate the user", async () => {
       const response = await request(httpServer)
         .patch("/user/update")
         .send({
@@ -91,5 +101,30 @@ describe("Starting App", () => {
     });
   });
 
+  describe("USER delete the user just updated /user/delete (DELETE)", () => {
+    it("should fail to delete the user when no invalid password", async () => {
+      const response = await request(httpServer)
+        .delete("/user/delete")
+        .send({
+          name: randomUser + "1",
+          email: `${randomUser}@gmail.com`,
+          password: `BAD${randomUser}1`,
+        });
+      expect(response.status).toBe(401);
+    });
+
+    it("should delete the user", async () => {
+      const response = await request(httpServer)
+        .delete("/user/delete")
+        .send({
+          name: randomUser + "1",
+          email: `${randomUser}@gmail.com`,
+          password: `${randomUser}1`,
+        });
+      expect(response.status).toBe(200);
+      expect(response.text).toBe("true");
+    });
+  });
+
   //afegir delete user
 });