fix(docx-compare): preserve machine-readable stdout - #785
Merged
Conversation
Remove the unconditional atomization diagnostic because comparison callers reserve stdout for their structured result. A focused regression test holds atomizeTree silent so future diagnostics cannot corrupt CLI JSON pipelines. Fixes: #783
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Aggregate and post reviewOverall: PASS (5 pass, 0 warn, 0 error, 12 skipped, 17 total)
|
Member
Author
✅ Post-merge smoke passedMerged: Steps
Real-world fixture
Visual evidence: skipped — the change only affects process streams and is structurally invisible in a rendered document. Prod: ✅ Vercel deployment for merge commit is successful ( Log: Cleanup
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[DEBUG] atomizeTreewrite to stdoutatomizeTreesilent on stdoutRoot cause
atomizeTreecalledconsole.logunconditionally, so the diagnostic was interleaved with thesafe-docx compareJSON result and broke machine consumers such asjq.Impact
Stdout once again belongs exclusively to the CLI's machine-readable comparison result. This is intentionally a narrow fix and does not introduce a logging framework or alter the result schema.
Validation
safe-docx compare ... --certificate-format llm | jq -e .safe-docx compare ... --certificate-format full | jq -e .Fixes #783