Dedup AgentCLI adapters: hoist read_hook_payload + resolve_model to base, drop dead CONFIG_MOUNT - #395
Merged
Merged
Conversation
tildesrc
force-pushed
the
panopticon/agent-cli-dedup
branch
2 times, most recently
from
August 24, 2026 15:15
e5f0fe8 to
c899ce0
Compare
…ase, drop dead CONFIG_MOUNT read_hook_payload was byte-for-byte identical in claude.py and codex.py; resolve_model had the same shape in both, differing only in mapping contents. Both are now single concrete implementations on AgentCLI; adapters supply MODEL_TIERS: ClassVar[Mapping[str, str]] for per-CLI model ids. CONFIG_MOUNT in local_runner.py was a dead constant with zero callers. Behavior-preserving refactor. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
tildesrc
force-pushed
the
panopticon/agent-cli-dedup
branch
from
August 24, 2026 15:23
c899ce0 to
dd8a5c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
read_hook_payloadwas byte-for-byte identical inclaude.pyandcodex.py— hoisted to a single concrete implementation onAgentCLIbase; adapters inherit it with no override.resolve_modelhad the same structure in both adapters, differing only in mapping contents — hoisted to the base, reading a per-adapterMODEL_TIERS: ClassVar[Mapping[str, str]]attribute (replacing two module-level_MODEL_TIERSdicts and two overrides).CONFIG_MOUNTinsessionservice/local_runner.pywas a dead constant with zero callers — deleted.test_read_hook_payload_tolerates_empty_and_invalidandtest_resolve_model_passes_unknown_values_throughmoved totest_cli_base.py(tested once); per-adapter tests keep only theirMODEL_TIERSmapping assertions.Behavior-preserving refactor.
make checkpasses (ruff + mypy + 1046 tests).🤖 Generated with Claude Code