-
Notifications
You must be signed in to change notification settings - Fork 8
Merge fork into main #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
* Add launch.json
* fix codegen for k8s 4.10.0 provider * clean up myriad and k8s fsproj files
…viders (cagyirey#5) * convert nuget to paket, use .net8
* aws 6.32->6.33; tls 5.0.2->5.0.3; fix kubernetes and azure providers * indicate rebuild of all providers
* Update build system to use FAKE 6 and Github Actions (cagyirey#9) * use miniscaffold; upgrade FAKE * feat(build): nuget package versioning, publish prerelease * add global.json; only use .net 8 sdk (cagyirey#10) * feat(GHA): build on pr; fantomas only formats src (cagyirey#11) * fix(build): fix build order and references for providers using Pulumi.FSHarp.Myriad (cagyirey#12) * fix(build): fix build order and references for providers using Pulumi.FSHarp.Myriad * fix publish url and nuget package versioning (cagyirey#13) * fix(nuget): use api/v2/package publish url suffix * replace paket push with nuget * fix(build): use correct nuget uri suffix * fix(gha): +package publish permissions * Automatically run Paket Update in CI (cagyirey#14) * feat(gha): +paket update cronjob * feat(gha) +publishprovider build targets
* fix(gha): +contents write permissions, use github-actions[bot] as pr owner * only publish extensions on changes to src
…blish Extensions" (cagyirey#21)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Revert "Paket Update for 06/17/2024 22:04:16 (cagyirey#25)" This reverts commit 699b1d8. * fix detection of providers requiring rebuild
…rey#28) * fix pulumi.fsharp.azure dependencies; improved republish logic * fix(providers/azure): paket.references order
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ckages. (cagyirey#37) * fix(compiler-plugin): generate ComponentResourceOptions for resources with isComponent=true * Split CI for core and myriad extension
* fix nuget package version check * build and test on all prs * clean up build script
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
@NatElkins thanks, @cagyirey has a lot of useful changes. could anyone split the PR into smaller chunks? as it is, it's not easy to review, merge and test individual changes. |
|
It would be pretty cool if we could merge both efforts since this library is excellent and by adding more contributors the bus factor for it would be a bit higher and the already small pool of F#/Pulumi users would benefit greatly. |
thank you, @purkhusid I would love to merge changes, but this PR is massive and, unfortunately, despite being grateful for the contributions, I have very little time to go through all the changes and prioritize the code review. Of course, you're more than welcome to take it and split it in smaller feature chunks and submit the PRs if you can. |
This PR is the result of merging
masterfrom this repo intomainfrom @cagyirey 's fork.Most of the changes fall into one of the following categories:
I thought I would open this PR just to continue the conversation.
@UnoSD , @cagyirey , what do you think?