fix(a2a/chat-client): preserve active task id - #173
Open
horaceewang-TT wants to merge 1 commit into
Open
Conversation
damaz91
approved these changes
Aug 11, 2026
damaz91
left a comment
Contributor
There was a problem hiding this comment.
LGTM. The fix correctly replaces the 'in' operator with '.includes()' for the array value check in JavaScript.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the A2A chat client active task state check. The previous code used the
inoperator to test whether the task state was one of the active states, which checks array indexes instead of array values in JavaScript. This caused active task states such asworking,submitted, andinput-requiredto be missed, incorrectly clearingtaskId.This change uses
.includes()so the client preserves the active task ID while the task is still in progress.Category (Required)
Please select one or more categories that apply to this change.
ucp-schematool (resolver, linter, validator). (Requires Maintainer approval)Related Issues
Checklist
!for breaking changes).Screenshots / Logs (if applicable)
No UI changes.
Build validation passed with
npm run build.vite v8.0.16 building client environment for production...
✓ 26 modules transformed.
✓ built in 88ms