fix: use configured discount code in totals test - #80
Merged
damaz91 merged 2 commits intoAug 11, 2026
Merged
Conversation
damaz91
approved these changes
Aug 11, 2026
nicholasjameshall
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
totals_test.pydefined a module-level_DISCOUNT_CODEand used it when driving the discounted checkout helper:The rest of the conformance suite reads the test discount code through
fixture_ctx.get_test_discount_code(), which comes fromvalid_discount_codeinthe configured fixture data with the existing fallback chain. The hardcoded
"10OFF"only matches the default fixture. A server tested with a non-defaultfixture, for example
"PROMO20", would receive an unrecognized discount code,return no
discounttotals entry, and maketest_discount_entry_is_negativeskip instead of checking the negative-sign invariant.
Fix: use
self.fixture_ctx.get_test_discount_code()in_discounted_checkout_totals()so the totals sign test applies the same discountcode as the active fixture.
Category (Required)
Related Issues
N/A
Type of change
Is this a Breaking Change or Removal?
N/A — test-only fix, no schema/field removal.
Checklist
Screenshots / Logs (if applicable)
N/A — test-only conformance fix.