Skip to content

NetworkDictionary.cs: fixed CS1620 errors. #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

NetworkDictionary.cs: fixed CS1620 errors. #251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions com.community.netcode.extensions/Runtime/NetworkDictionary/NetworkDictionary.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,10 @@ public override void ReadField(FastBufferReader reader)

for (int i = 0; i < count; i++)
{
NetworkVariableSerialization<TKey>.Read(reader, out TKey key);
NetworkVariableSerialization<TValue>.Read(reader, out TValue value);
TKey key = new TKey();
TValue value = new TValue();
NetworkVariableSerialization<TKey>.Read(reader, ref key);
NetworkVariableSerialization<TValue>.Read(reader, ref value);
m_Keys.Add(key);
m_Values.Add(value);
}
Expand All @@ -225,8 +227,10 @@ public override void ReadDelta(FastBufferReader reader, bool keepDirtyDelta)
{
case NetworkDictionaryEvent<TKey, TValue>.EventType.Add:
{
NetworkVariableSerialization<TKey>.Read(reader, out TKey key);
NetworkVariableSerialization<TValue>.Read(reader, out TValue value);
TKey key = new TKey();
TValue value = new TValue();
NetworkVariableSerialization<TKey>.Read(reader, ref key);
NetworkVariableSerialization<TValue>.Read(reader, ref value);

if (m_Keys.Contains(key))
{
Expand Down Expand Up @@ -256,7 +260,8 @@ public override void ReadDelta(FastBufferReader reader, bool keepDirtyDelta)
break;
case NetworkDictionaryEvent<TKey, TValue>.EventType.Remove:
{
NetworkVariableSerialization<TKey>.Read(reader, out TKey key);
TKey key = new TKey();
NetworkVariableSerialization<TKey>.Read(reader, ref key);
var index = m_Keys.IndexOf(key);

if (index == -1)
Expand Down Expand Up @@ -288,8 +293,10 @@ public override void ReadDelta(FastBufferReader reader, bool keepDirtyDelta)
break;
case NetworkDictionaryEvent<TKey, TValue>.EventType.Value:
{
NetworkVariableSerialization<TKey>.Read(reader, out TKey key);
NetworkVariableSerialization<TValue>.Read(reader, out TValue value);
TKey key = new TKey();
TValue value = new TValue();
NetworkVariableSerialization<TKey>.Read(reader, ref key);
NetworkVariableSerialization<TValue>.Read(reader, ref value);
var index = m_Keys.IndexOf(key);

if (index == -1)
Expand Down