fix: Fix incorrect privilegekeyadd command #44
Conversation
| @@ -9,7 +9,7 @@ Features | |||
| Installation | |||
| ------------ | |||
| ```sh | |||
| go get -u github.com/multiplay/go-ts3 | |||
| go get -u github.com/honeybbq/go-ts3 | |||
There was a problem hiding this comment.
Bug: You’ve changed the name of the module which isn’t needed
| @@ -44,10 +44,6 @@ func main() { | |||
| } | |||
| ``` | |||
|
|
|||
| Documentation | |||
There was a problem hiding this comment.
suggestion: this should be updated to point to thr new docs site instead of removed
| @@ -461,3 +461,16 @@ func (s *ServerMethods) ClientDBList() ([]*DBClient, error) { | |||
| } | |||
| return dbclients, nil | |||
| } | |||
|
|
|||
| type Snapshot struct { | |||
There was a problem hiding this comment.
Question: this looks unrelated to the described change
| @@ -402,6 +402,18 @@ func testCmdsServer(t *testing.T, c *Client) { | |||
| assert.Equal(t, expected, clients) | |||
| } | |||
|
|
|||
| serversnapshotcreate := func(t *testing.T) { | |||
There was a problem hiding this comment.
As above unrelated changes
| @@ -368,7 +368,7 @@ func (s *ServerMethods) PrivilegeKeyAdd(ttype, id1, id2 int, options ...CmdArg) | |||
| Token string | |||
| }{} | |||
| options = append(options, NewArg("tokentype", ttype), NewArg("tokenid1", id1), NewArg("tokenid2", id2)) | |||
| _, err := s.ExecCmd(NewCmd("privilegekeylist").WithArgs(options...).WithResponse(&t)) | |||
| _, err := s.ExecCmd(NewCmd("privilegekeyadd").WithArgs(options...).WithResponse(&t)) | |||
There was a problem hiding this comment.
This looks like the only needed change
There was a problem hiding this comment.
I forgot to close the pull request. Since your repository hasn’t been updated for a long time, I forked it and made the changes myself.
There was a problem hiding this comment.
This looks like the only needed change
I forgot that the pull request here is based on the main branch after I forked it. Sorry about that.
|
I have opened a new pull request, please review it. |
New Pull Request