Skip to content

Conversation

karasusan
Copy link
Collaborator

@karasusan karasusan commented Sep 2, 2025

This pull request introduces new auto-generated CI configuration files and platform-specific scripts to support infrastructure instability detection and package workflows for WebRTC and Preview APV jobs. The changes ensure that instability detection is integrated into the build and test pipelines across Windows, Linux, and MacOS environments, and add comprehensive job definitions for package packing, API validation, and preview APV testing.

Integration of infrastructure instability detection:

  • Added new platform-specific scripts for Windows (infrastructure-instability-detection-win.cmd), Linux (infrastructure-instability-detection-linux.sh), and MacOS (infrastructure-instability-detection-mac.sh) to automate downloading, extracting, and running infrastructure instability detection tools and patterns as part of CI jobs. [1] [2] [3]

New and updated CI job definitions:

  • Introduced .yamato/wrench/package-pack-jobs.yml to define the job for packing WebRTC packages, including running the Linux instability detection script after packaging.
  • Added .yamato/wrench/api-validation-jobs.yml to define API validation jobs for WebRTC on Windows, integrating the Windows instability detection script in the job's after steps.
  • Created .yamato/wrench/preview-a-p-v.yml to define Preview APV jobs for multiple Unity editor versions and platforms (Windows, Linux, MacOS), including integration with the appropriate instability detection script for each platform.

Pipeline enhancements and artifact management:

  • Each new job configuration includes detailed artifact collection for logs, crash dumps, and test results, improving traceability and debugging in CI workflows. [1] [2] [3]

These changes collectively improve the robustness of the CI pipeline by automating instability detection and standardizing package and test workflows across platforms.

@karasusan karasusan requested a review from Copilot September 2, 2025 06:39
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR installs wrench tools to set up CI/CD infrastructure for the WebRTC package. The changes include adding configuration files, build scripts, and generated Yamato job definitions to support automated testing, validation, and publishing workflows.

  • Adds Wrench tool configuration and onboarding scripts for project setup
  • Installs .NET project files and solution for running the Wrench recipe engine
  • Generates comprehensive Yamato CI/CD job definitions for package testing and publishing

Reviewed Changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Tools/Wrench/onboard.py Python script to onboard projects onto Wrench tooling
Tools/Wrench/regenerate.sh/.bat Shell scripts to regenerate Wrench job definitions
Tools/Wrench/WebRTC.Cookbook.csproj .NET project file for the Wrench recipe engine
Tools/Wrench/Settings/WebRTCSettings.cs C# settings configuration for WebRTC package release options
Tools/Wrench/Program.cs Main program entry point for the recipe engine
.yamato/wrench/*.yml Generated Yamato job definitions for validation, promotion, and packaging
.yamato/generated-scripts/* Infrastructure instability detection scripts

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.



def create_package_option(name, first):
initial_char=""
Copy link
Preview

Copilot AI Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space around the assignment operator. Should be initial_char = \"\" to follow Python PEP 8 style guidelines.

Suggested change
initial_char=""
initial_char = ""

Copilot uses AI. Check for mistakes.

update_shell_scripts(root_dir)


if "__main__" in __name__:
Copy link
Preview

Copilot AI Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition should be if __name__ == \"__main__\": instead of if \"__main__\" in __name__:. The current condition could match partial strings and is not the standard Python idiom.

Suggested change
if "__main__" in __name__:
if __name__ == "__main__":

Copilot uses AI. Check for mistakes.

@karasusan karasusan merged commit d420462 into main Sep 12, 2025
58 of 66 checks passed
@karasusan karasusan deleted the ci/wrench branch September 12, 2025 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant