-
Notifications
You must be signed in to change notification settings - Fork 210
ci: Install wrench tools #1097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Install wrench tools #1097
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR installs wrench tools to set up CI/CD infrastructure for the WebRTC package. The changes include adding configuration files, build scripts, and generated Yamato job definitions to support automated testing, validation, and publishing workflows.
- Adds Wrench tool configuration and onboarding scripts for project setup
- Installs .NET project files and solution for running the Wrench recipe engine
- Generates comprehensive Yamato CI/CD job definitions for package testing and publishing
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
Tools/Wrench/onboard.py | Python script to onboard projects onto Wrench tooling |
Tools/Wrench/regenerate.sh/.bat | Shell scripts to regenerate Wrench job definitions |
Tools/Wrench/WebRTC.Cookbook.csproj | .NET project file for the Wrench recipe engine |
Tools/Wrench/Settings/WebRTCSettings.cs | C# settings configuration for WebRTC package release options |
Tools/Wrench/Program.cs | Main program entry point for the recipe engine |
.yamato/wrench/*.yml | Generated Yamato job definitions for validation, promotion, and packaging |
.yamato/generated-scripts/* | Infrastructure instability detection scripts |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
||
|
||
def create_package_option(name, first): | ||
initial_char="" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing space around the assignment operator. Should be initial_char = \"\"
to follow Python PEP 8 style guidelines.
initial_char="" | |
initial_char = "" |
Copilot uses AI. Check for mistakes.
update_shell_scripts(root_dir) | ||
|
||
|
||
if "__main__" in __name__: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The condition should be if __name__ == \"__main__\":
instead of if \"__main__\" in __name__:
. The current condition could match partial strings and is not the standard Python idiom.
if "__main__" in __name__: | |
if __name__ == "__main__": |
Copilot uses AI. Check for mistakes.
This pull request introduces new auto-generated CI configuration files and platform-specific scripts to support infrastructure instability detection and package workflows for WebRTC and Preview APV jobs. The changes ensure that instability detection is integrated into the build and test pipelines across Windows, Linux, and MacOS environments, and add comprehensive job definitions for package packing, API validation, and preview APV testing.
Integration of infrastructure instability detection:
infrastructure-instability-detection-win.cmd
), Linux (infrastructure-instability-detection-linux.sh
), and MacOS (infrastructure-instability-detection-mac.sh
) to automate downloading, extracting, and running infrastructure instability detection tools and patterns as part of CI jobs. [1] [2] [3]New and updated CI job definitions:
.yamato/wrench/package-pack-jobs.yml
to define the job for packing WebRTC packages, including running the Linux instability detection script after packaging..yamato/wrench/api-validation-jobs.yml
to define API validation jobs for WebRTC on Windows, integrating the Windows instability detection script in the job'safter
steps..yamato/wrench/preview-a-p-v.yml
to define Preview APV jobs for multiple Unity editor versions and platforms (Windows, Linux, MacOS), including integration with the appropriate instability detection script for each platform.Pipeline enhancements and artifact management:
These changes collectively improve the robustness of the CI pipeline by automating instability detection and standardizing package and test workflows across platforms.