FIX: out of range exception when pressing undo after creating and editing a new control scheme (ISXB-1607) (DRAFT)

Packages/com.unity.inputsystem/InputSystem/Editor/UITKAssetEditor/Commands/ControlSchemeCommands.cs

@@ -145,10 +145,16 @@
         {
             return (in InputActionsEditorState state) =>
             {
-                var controlSchemeSerializedProperty = state.selectedControlSchemeIndex == -1 ? null :
-                    state.serializedObject
-                        .FindProperty(nameof(InputActionAsset.m_ControlSchemes))
-                        .GetArrayElementAtIndex(state.selectedControlSchemeIndex);
+                SerializedProperty controlSchemeSerializedProperty = null;
+                var serializedProperty = state.serializedObject
+                    .FindProperty(nameof(InputActionAsset.m_ControlSchemes));
+
+                if (state.selectedControlSchemeIndex < serializedProperty.arraySize)
+                {
+                    controlSchemeSerializedProperty = state.selectedControlSchemeIndex == -1 ? null :
+                        serializedProperty
+                            .GetArrayElementAtIndex(state.selectedControlSchemeIndex);
+                }
 
                 if (controlSchemeSerializedProperty == null)
                 {

Packages/com.unity.inputsystem/InputSystem/Editor/UITKAssetEditor/Views/ControlSchemesView.cs

@@ -108,7 +108,6 @@ private void RemoveDeviceRequirement()
         public override void RedrawUI(InputControlScheme viewState)
         {
             rootElement.Q<TextField>(kControlSchemeNameTextField).value = string.IsNullOrEmpty(m_NewName) ? viewState.name : m_NewName;
-
             m_ListView.itemsSource?.Clear();
             m_ListView.itemsSource = viewState.deviceRequirements.Count > 0 ?
                 viewState.deviceRequirements.Select(r => (r.controlPath, r.isOptional)).ToList() :
@@ -128,7 +127,7 @@ private void SaveAndClose()
             CloseView();
         }
 
-        private void Cancel()
+        internal void Cancel()
         {
             // Reload the selected ControlScheme values from the SerilaizedProperty and throw away any changes
             Dispatch(ControlSchemeCommands.ResetSelectedControlScheme());

Packages/com.unity.inputsystem/InputSystem/Editor/UITKAssetEditor/Views/InputActionsEditorView.cs

@@ -2,6 +2,7 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
+using System.Threading.Tasks;
 using UnityEditor;
 using UnityEditor.UIElements;
 using UnityEngine.UIElements;
@@ -23,6 +24,8 @@
         private readonly ToolbarButton m_SaveButton;
 
         private readonly Action m_SaveAction;
+
+        private ControlSchemesView m_ControlSchemesView;
 
         public InputActionsEditorView(VisualElement root, StateContainer stateContainer, bool isProjectSettings,
                                       Action saveAction)
@@ -104,6 +107,27 @@
                 });
 
             s_OnPasteCutElements.Add(this);
+
+            Undo.undoRedoPerformed += CheckForInvalidControlSchemeInOneFrame;
+        }
+
+        private async void CheckForInvalidControlSchemeInOneFrame()
+        {
+            try
+            {
+                await Task.Delay(1);
+                var state = stateContainer.GetState();
+                var viewState = ViewStateSelector.GetViewState(state);
+                var elementAtOrDefault = viewState.controlSchemes?.ElementAtOrDefault(viewState.selectedControlSchemeIndex);
+                if (viewState.selectedControlSchemeIndex != -1 && elementAtOrDefault == default(InputControlScheme))
+                {
+                    m_ControlSchemesView?.Cancel();
+                }
+            }
+            catch (Exception e)
+            {
+                Debug.LogException(e);
+            }
         }
 
         private void OnReset()
@@ -156,9 +180,8 @@
 
             if (viewState.controlSchemes.Any())
             {
-                m_ControlSchemesToolbar.text = viewState.selectedControlSchemeIndex == -1
-                    ? "All Control Schemes"
-                    : viewState.controlSchemes.ElementAt(viewState.selectedControlSchemeIndex).name;
+                var elementAtOrDefault = viewState.controlSchemes.ElementAtOrDefault(viewState.selectedControlSchemeIndex);
+                m_ControlSchemesToolbar.text = elementAtOrDefault == default ? "All Control Schemes" : elementAtOrDefault.name;
 
                 m_ControlSchemesToolbar.menu.AppendAction("All Control Schemes", _ => SelectControlScheme(-1),
                     viewState.selectedControlSchemeIndex == -1 ? DropdownMenuAction.Status.Checked : DropdownMenuAction.Status.Normal);
@@ -186,7 +209,7 @@
                 return;
             }
             m_DevicesToolbar.SetEnabled(true);
-            var currentControlScheme = viewState.controlSchemes.ElementAt(viewState.selectedControlSchemeIndex);
+            var currentControlScheme = viewState.controlSchemes.ElementAtOrDefault(viewState.selectedControlSchemeIndex);
             if (viewState.selectedDeviceIndex == -1)
                 m_DevicesToolbar.text = "All Devices";
 
@@ -228,12 +251,15 @@
 
         private void ShowControlSchemeEditor(VisualElement parent, bool updateExisting = false)
         {
-            var controlSchemesView = CreateChildView(new ControlSchemesView(parent, stateContainer, updateExisting));
-            controlSchemesView.UpdateView(stateContainer.GetState());
-
-            controlSchemesView.OnClosing += _ => DestroyChildView(controlSchemesView);
+            m_ControlSchemesView = CreateChildView(new ControlSchemesView(parent, stateContainer, updateExisting));
+            m_ControlSchemesView.UpdateView(stateContainer.GetState());
+            m_ControlSchemesView.OnClosing += _ =>
+            {
+                DestroyChildView(m_ControlSchemesView);
+                m_ControlSchemesView = null;
+            };
         }
-
+        
         private void SelectControlScheme(int controlSchemeIndex)
         {
             Dispatch(ControlSchemeCommands.SelectControlScheme(controlSchemeIndex));
@@ -258,6 +284,7 @@
         {
             base.DestroyView();
             s_OnPasteCutElements.Remove(this);
+            Undo.undoRedoPerformed -= CheckForInvalidControlSchemeInOneFrame;
         }
 
         public void OnPaste(InputActionsEditorState state)