-
Notifications
You must be signed in to change notification settings - Fork 326
CHANGE: Re-enable tvOS tests in CI #2197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2197 +/- ##
========================================
Coverage 68.11% 68.12%
========================================
Files 367 367
Lines 53629 53629
========================================
+ Hits 36529 36534 +5
+ Misses 17100 17095 -5
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
@Pauliusd01 do we still want this to be merged? |
I think I was spooked by iOS failures (back when it wasn't clear It's an instability) but it might be fine to merge, will take another look a bit later |
Description
TvOS tests were unstable and disabled for a fairly long time, the code causing the instabilities is fixed by UUM-72211. So It should be fine to re-enable them. ISX-2144
Testing status & QA
Re-ran the tests a few times without failure
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Checklist
Before review:
Changed
,Fixed
,Added
sections.Area_CanDoX
,Area_CanDoX_EvenIfYIsTheCase
,Area_WhenIDoX_AndYHappens_ThisIsTheResult
.During merge:
NEW: ___
.FIX: ___
.DOCS: ___
.CHANGE: ___
.RELEASE: 1.1.0-preview.3
.After merge: