Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a timing error at ModelImporterConfigurator #163

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix a timing error at ModelImporterConfigurator #163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Editor/System/Importers/ModelImporterConfigurator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,6 +427,9 @@ private void OverwriteImportSettings(ModelImporter target, ModelImporter referen

target.animationType = reference.animationType;
target.animationWrapMode = reference.animationWrapMode;
//Fixing the sourceAvatar set to null results in the avatarSetup being forced to change to CreateFromThisModel,
//so the configured avatarSetup value cannot be applied correctly, which is a timing error.
target.sourceAvatar = reference.sourceAvatar;
#if UNITY_2019_3_OR_NEWER
target.avatarSetup = reference.avatarSetup;
#endif
Expand Down Expand Up @@ -510,8 +513,6 @@ private void OverwriteImportSettings(ModelImporter target, ModelImporter referen
target.skinWeights = reference.skinWeights;
target.sortHierarchyByName = reference.sortHierarchyByName;
#endif

target.sourceAvatar = reference.sourceAvatar;
target.swapUVChannels = reference.swapUVChannels;
target.useFileScale = reference.useFileScale;
target.useFileUnits = reference.useFileUnits;
Expand Down