Skip to content

Remove misleading CommonInst::method #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025
Merged

Remove misleading CommonInst::method #333

merged 1 commit into from
Jul 28, 2025

Conversation

Lipen
Copy link
Member

@Lipen Lipen commented Jul 24, 2025

This PR removes the misleading val method: CommonMethod accessor in CommonInst. Instead, the user should use inst.location.method, if he wants the method in which the statement is located. For call statements, stmt.method typically denotes the callee, which was confused with inst.method until this PR.

This PR also removes the unused InstList interface.

Copy link

codecov bot commented Jul 24, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.83%. Comparing base (4ba634a) to head (5099ce6).
⚠️ Report is 1 commits behind head on neo.

Files with missing lines Patch % Lines
...ain/kotlin/org/jacodb/impl/cfg/JcBlockGraphImpl.kt 0.00% 2 Missing ⚠️
.../main/kotlin/org/jacodb/ets/utils/BlockCfgToDot.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                neo     #333   +/-   ##
=========================================
  Coverage     69.82%   69.83%           
  Complexity     2491     2491           
=========================================
  Files           275      275           
  Lines         15557    15556    -1     
  Branches       2342     2342           
=========================================
  Hits          10863    10863           
+ Misses         3769     3768    -1     
  Partials        925      925           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Jul 24, 2025

Test Results

  215 files  ±0    215 suites  ±0   15m 46s ⏱️ -4s
  711 tests ±0    699 ✅ ±0  12 💤 ±0  0 ❌ ±0 
1 977 runs  ±0  1 927 ✅ ±0  50 💤 ±0  0 ❌ ±0 

Results for commit 5099ce6. ± Comparison against base commit 4ba634a.

♻️ This comment has been updated with latest results.

@Lipen Lipen force-pushed the lipen/remove-inst-method branch from 8d253fd to 16b0733 Compare July 28, 2025 10:14
@Lipen Lipen force-pushed the lipen/remove-inst-method branch from def6612 to 5099ce6 Compare July 28, 2025 11:52
@Lipen Lipen merged commit 5c8f0eb into neo Jul 28, 2025
8 of 9 checks passed
@Lipen Lipen deleted the lipen/remove-inst-method branch July 28, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants