-
Notifications
You must be signed in to change notification settings - Fork 234
ROUTE-475 allowlist WETH #1130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROUTE-475 allowlist WETH #1130
Conversation
Adding WETH to the allow list
Graphite Automations"Request reviewers once CI passes on routing-api repo" took an action on this PR • (06/13/25)5 reviewers were added to this PR based on Siyu Jiang (See-You John)'s automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but curious do we need to hardcode these ones? we probably get TVL anyway from the subgraph right?
lib/util/v4HooksPoolsFiltering.ts
Outdated
) { | ||
pool.tvlETH = 57736 // https://app.uniswap.org/explore/pools/ethereum/0x88e6A0c2dDD26FEEb64F039a2c41296FcB3f5640 | ||
pool.tvlUSD = 104153666 // https://app.uniswap.org/explore/pools/ethereum/0x88e6A0c2dDD26FEEb64F039a2c41296FcB3f5640 | ||
log.debug(`Setting tvl for flETH/FLNCH pool ${JSON.stringify(pool)}`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The log message contains an incorrect pool name. It refers to "flETH/FLNCH pool" but this code section is handling the MAINNET WETH/ETH pool as indicated by the comment on line 53. The message should be updated to:
log.debug(`Setting tvl for MAINNET WETH/ETH pool ${JSON.stringify(pool)}`)
This will ensure the logging accurately reflects which pool is being processed.
log.debug(`Setting tvl for flETH/FLNCH pool ${JSON.stringify(pool)}`) | |
log.debug(`Setting tvl for MAINNET WETH/ETH pool ${JSON.stringify(pool)}`) |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Thanks for the review, @cgkol - WETH is not working rn and I'm debugging and splitting the WETH and the WstETH PRs since:
I will debug more from here |
We do need to inflate ETH/WETH hooked pool because 0 TVL pool will not get picked up by SOR during get-candidate-pools. @cgkol However as @yucanliu indicated, merely inflating ETH/WETH is not sufficient to make this hooked pool routing work somehow. More debugging needed. Hoping to see more progress being made, but also happy to help. |
…nual works for 0TVL pools
77e535a
to
768cd29
Compare
id: '0x82af49447d8a07e3bd95bd0d56f35241523fbab1', | ||
}, | ||
tvlETH: 23183, | ||
tvlUSD: 60342168, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a discrepancy in the TVL USD value for the Arbitrum ETH/WETH pool. In addWethPools()
, the value is set to 60342168
, but in v4HooksPoolsFiltering.ts
, it's set to 41820637
. These values should be consistent to ensure proper behavior. Consider updating one of these values to match the other, preferably using the most current data from the referenced pool.
tvlUSD: 60342168, | |
tvlUSD: 41820637, |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Adding WETH to the allow list