Skip to content

Conversation

yucanliu
Copy link
Contributor

Adding WETH to the allow list

Adding WETH to the allow list
@yucanliu yucanliu self-assigned this Jun 13, 2025
@graphite-app graphite-app bot requested review from a team, cgkol, jsy1218 and xrsv June 13, 2025 20:08
Copy link
Contributor

graphite-app bot commented Jun 13, 2025

Graphite Automations

"Request reviewers once CI passes on routing-api repo" took an action on this PR • (06/13/25)

5 reviewers were added to this PR based on Siyu Jiang (See-You John)'s automation.

Copy link
Collaborator

@cgkol cgkol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but curious do we need to hardcode these ones? we probably get TVL anyway from the subgraph right?

) {
pool.tvlETH = 57736 // https://app.uniswap.org/explore/pools/ethereum/0x88e6A0c2dDD26FEEb64F039a2c41296FcB3f5640
pool.tvlUSD = 104153666 // https://app.uniswap.org/explore/pools/ethereum/0x88e6A0c2dDD26FEEb64F039a2c41296FcB3f5640
log.debug(`Setting tvl for flETH/FLNCH pool ${JSON.stringify(pool)}`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The log message contains an incorrect pool name. It refers to "flETH/FLNCH pool" but this code section is handling the MAINNET WETH/ETH pool as indicated by the comment on line 53. The message should be updated to:

log.debug(`Setting tvl for MAINNET WETH/ETH pool ${JSON.stringify(pool)}`)

This will ensure the logging accurately reflects which pool is being processed.

Suggested change
log.debug(`Setting tvl for flETH/FLNCH pool ${JSON.stringify(pool)}`)
log.debug(`Setting tvl for MAINNET WETH/ETH pool ${JSON.stringify(pool)}`)

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@yucanliu
Copy link
Contributor Author

Approved, but curious do we need to hardcode these ones? we probably get TVL anyway from the subgraph right?

Thanks for the review, @cgkol - WETH is not working rn and I'm debugging and splitting the WETH and the WstETH PRs since:

  1. WETH requires more debugging from our side
  2. WstETH is blocked by the protocol team

I will debug more from here

@jsy1218
Copy link
Member

jsy1218 commented Jun 13, 2025

Approved, but curious do we need to hardcode these ones? we probably get TVL anyway from the subgraph right?

Thanks for the review, @cgkol - WETH is not working rn and I'm debugging and splitting the WETH and the WstETH PRs since:

  1. WETH requires more debugging from our side

  2. WstETH is blocked by the protocol team

I will debug more from here

We do need to inflate ETH/WETH hooked pool because 0 TVL pool will not get picked up by SOR during get-candidate-pools. @cgkol

However as @yucanliu indicated, merely inflating ETH/WETH is not sufficient to make this hooked pool routing work somehow. More debugging needed. Hoping to see more progress being made, but also happy to help.

@yucanliu yucanliu force-pushed the yucanliu/route-475-allowlist-new-hook-wethhook branch from 77e535a to 768cd29 Compare June 16, 2025 21:33
id: '0x82af49447d8a07e3bd95bd0d56f35241523fbab1',
},
tvlETH: 23183,
tvlUSD: 60342168,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a discrepancy in the TVL USD value for the Arbitrum ETH/WETH pool. In addWethPools(), the value is set to 60342168, but in v4HooksPoolsFiltering.ts, it's set to 41820637. These values should be consistent to ensure proper behavior. Consider updating one of these values to match the other, preferably using the most current data from the referenced pool.

Suggested change
tvlUSD: 60342168,
tvlUSD: 41820637,

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@yucanliu
Copy link
Contributor Author

yucanliu commented Jun 18, 2025

We decided to close this one and split into 5 for each chain:
#1137: MAINNET
#1136: BASE
#1135: OPTIMISM
#1134: UNICHAIN
#1133: ARBITRUM_ONE

@yucanliu yucanliu closed this Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants