chore: bump sor to 4.21.7 - fix: configurable liqudity threshold #1102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
133
to
137
| true, | ||
| v3TrackedEthThreshold, | ||
| v3UntrackedUsdThreshold, | ||
| v3LiquidityThreshold, | ||
| v3SubgraphUrlOverride(ChainId.MAINNET) |
There was a problem hiding this comment.
This V3Protocol constructor call (and all similar calls throughout the file) is passing 8 arguments, but the constructor is only expecting 7. The new 'v3LiquidityThreshold' parameter has been added here, but the V3Protocol class definition needs to be updated to accept this new parameter. Similar updates are needed for all V3Protocol and V4Protocol instantiations in this file.
Spotted by Diamond (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.