unified-core module and some fixes / minor changes #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds the
unified-core
module. Previously, the project was lacking a way of listening to custom block placing / breaking, so it wasn't possible to register newly placed energy storages. I've decided not to put those methods into theunified-energy
module, so that the project can be expanded in the future without needing to listen to both placing of energy storages and (for example) item storages.The current idea is to implement the
UnifiedBlockListener
in your project and then callUnifiedEnergy.getInstance().getEnergyStoragesAt
(and in the future also something likeUnifiedItems.getInstance().getItemStorageAt
). I've also already started to implement this in Nova. You can look at our implementation here.I've also updated the
EnergyNetworkManager#getEnergyStoragesIn
method to return a map ofLocation, EnergyStorage
and fixed a ConcurrentModificationException in the correspondingUnifiedEnergy
methods