Skip to content

Conversation

@TheOneWithTheBraid
Copy link
Contributor

  • BREAKING: remove async gaps from BuildContext
    • See README for migration
  • BREAKING: remove built-in provider storage
    • See README for migration
  • Fix missing await statement for asynchronous tasks

@p1gp1g
Copy link
Member

p1gp1g commented Aug 14, 2024

That's OK to remove the dialog from the unifiedpush package, if we provide a unifiedpush_ui package that does it. I think this package should not depend on unifiedpush to reduce maintenance load.

If we go that way, then:

  1. We should publish unifiedpush_ui
  2. We should deprecate registerAppWithDialog
  3. Publish a new version
  4. Remove registerAppWithDialog in the next major version, which should happen in a few months

What do you think about this ? If you like the idea, do you want to help for the new lib ?

@p1gp1g
Copy link
Member

p1gp1g commented Aug 25, 2024

Gentle ping for the question @TheOneWithTheBraid

@TheOneWithTheBraid
Copy link
Contributor Author

TheOneWithTheBraid commented Aug 25, 2024 via email

@p1gp1g
Copy link
Member

p1gp1g commented Aug 25, 2024

Thanks for the answer, I'll also see if I've time to do it

@p1gp1g
Copy link
Member

p1gp1g commented Aug 28, 2024

What do you think about this solution ? https://codeberg.org/UnifiedPush/flutter-connector/pulls/1

* BREAKING: remove async gaps from `BuildContext`
  * See README for migration
* BREAKING: remove built-in provider storage
  * See README for migration
* Fix missing await statement for asynchronous tasks

Signed-off-by: The one with the braid <[email protected]>
@TheOneWithTheBraid
Copy link
Contributor Author

@p1gp1g It's now been a long while with deprecation notice. Can we slowly consider actually removing the deprecated dialogs ? I rebased this branch, it should now properly remove the deprecated methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants