Add kde support for hist

[gepcel]

Are you instrested in adding a kde support for hist for now?

Should close #794

[codecov]

Codecov Report

❌ Patch coverage is 96.66667% with 2 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
ultraplot/axes/plot.py	90.00%	2 Missing ⚠️

📢 Thoughts on this report? Let us know!

[cvanelteren]

This would require a few extra things. First an optional dependency in the install for scipy; a fallback + handling in the code added here and third tests.

[gepcel]

• First an optional dependency in the install for scipy;
• a fallback + handling in the code added here and
• third tests.

3/3 are done.

[cvanelteren]

• First an optional dependency in the install for scipy;

  • a fallback + handling in the code added here and

  • third tests.

2/3 are done. I don't know how to add fallback handling, raise an error if scipy is not installed? And I'm not sure if it's good practise to put one assert in one method or it's ok to put them together.

It's fine if you take this over, or you can leave comments about what else to do, and how to do it.

shouldn't the second bullet be done?

[gepcel]

I don't know what you mean by "fallback handling". Maybe you can explain a little or you can take it over.

[cvanelteren]

What I would do is make the scipy import optional and do a try except block and produce a warning if it is not installed; fallback may have been wrongly stated as this would imply we provide the kde itself

[gepcel]

What I would do is make the scipy import optional and do a try except block and produce a warning if it is not installed; fallback may have been wrongly stated as this would imply we provide the kde itself

Ok, I'll take a look, and add this. I actually did do a research how to calculate kde using pure numpy.

[gepcel]

Now you can review.

There's also from scipy.stats import gaussian_kde in def _apply_ridgeline and tests about ridgeline, without warnings.