Skip to content

Enable gridspec methods #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cvanelteren
Copy link
Contributor

Enable some methods that are disable to push the updates through update. This issues popped up in #270 where some editors require the use of these methods.

@cvanelteren
Copy link
Contributor Author

cvanelteren commented Aug 16, 2025

Running this through GHA to test the waters, as I am not sure if these methods can cause other issues. Will need to evaluate if this will cause any issues -- probably not but still.

@cvanelteren
Copy link
Contributor Author

To fix the issue in #270, we can remove the RunTimeError and raise a warning instead. To properly fix it we cannot remove the disablers as the funneling through update uses custom properties and would collide potentially with user settings.

Copy link

codecov bot commented Aug 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@cvanelteren cvanelteren marked this pull request as draft August 16, 2025 13:37
@cvanelteren
Copy link
Contributor Author

I would be more included to override the methods when necessary rather than disabling them. Will look at this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant