Add missing stdint includes #160
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: Community Contribution 👑
|
We got the same build errors in "production" in Fedora 42. Thanks for the patch! |
dreua
approved these changes
Apr 28, 2025
hroncok
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arcus uses C stdint types in several places, but the source code is missing stdint.h/cstdint includes.
This causes build errors when they aren't pulled in by some other dependency.
Context: This started appearing when the Debian package (an older version, but still affects the current release) was test-built with gcc 15: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1097162
I added a
#include <cstdint>in all source files where[u]int[nn]_ttypes are used.